From patchwork Tue May 7 14:16:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 242358 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7E9142C00B0 for ; Wed, 8 May 2013 01:26:38 +1000 (EST) Received: from localhost ([::1]:35533 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZiiu-0000CU-JT for incoming@patchwork.ozlabs.org; Tue, 07 May 2013 10:18:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZiiQ-0000C9-FQ for qemu-devel@nongnu.org; Tue, 07 May 2013 10:18:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZiiP-0005qB-7G for qemu-devel@nongnu.org; Tue, 07 May 2013 10:18:02 -0400 Received: from mail-wg0-x229.google.com ([2a00:1450:400c:c00::229]:34415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZiiP-0005pu-1Q for qemu-devel@nongnu.org; Tue, 07 May 2013 10:18:01 -0400 Received: by mail-wg0-f41.google.com with SMTP id y10so3934164wgg.2 for ; Tue, 07 May 2013 07:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references; bh=CaAv3fpyJ6EONWITe+yJ5fPToG1e1E2xrjSux4cc1tk=; b=AvRuDkCtmdm6DBUcMSLihW3+ybnnpa+iTEHGLYq2NXH6qTdBHLeygihWCsYlZ+bX3F NEioBlSoA/paNGOYmowx5znRoc0f+5d+SMpCFnhaFFbOVwBakebMpRvt0lt9K9iOJ5TR ecuqVuIxtqjA6K7LnEOxKCjhLG6ESaJFE8Xg+88vAcBxZSnQltBZxHG6cQnsYFFh/2Aw 3FDzVN8vJFGbSHHXRys3WtrcXR8K4HV+W00BAHnVrLZYxbaQxqzH22/wwkaONyrEfSdF cjO6Wibw2zlvBvMhJ+nUBcoToQdmuke6CIPmDLF8j5IsLldZJIQxxBdMarHUvHkPIWge EyjQ== X-Received: by 10.180.206.172 with SMTP id lp12mr3730347wic.11.1367936280421; Tue, 07 May 2013 07:18:00 -0700 (PDT) Received: from localhost.localdomain (93-34-176-20.ip50.fastwebnet.it. [93.34.176.20]) by mx.google.com with ESMTPSA id ge7sm3335978wib.6.2013.05.07.07.17.58 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 07 May 2013 07:17:59 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 7 May 2013 16:16:48 +0200 Message-Id: <1367936238-12196-11-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1367936238-12196-1-git-send-email-pbonzini@redhat.com> References: <1367936238-12196-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::229 Cc: aik@ozlabs.ru, jan.kiszka@siemens.com, qemulist@gmail.com, stefanha@redhat.com, david@gibson.dropbear.id.au Subject: [Qemu-devel] [PATCH 10/40] exec: remove obsolete comment X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org See how we call memory_region_section_addr two lines below to convert a physical address to a base address in the region. Signed-off-by: Paolo Bonzini Reviewed-by: Peter Maydell --- exec.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/exec.c b/exec.c index fccecf6..1dbd956 100644 --- a/exec.c +++ b/exec.c @@ -639,12 +639,6 @@ hwaddr memory_region_section_get_iotlb(CPUArchState *env, iotlb |= phys_section_rom; } } else { - /* IO handlers are currently passed a physical address. - It would be nice to pass an offset from the base address - of that region. This would avoid having to special case RAM, - and avoid full address decoding in every device. - We can't use the high bits of pd for this because - IO_MEM_ROMD uses these as a ram address. */ iotlb = section - phys_sections; iotlb += memory_region_section_addr(section, paddr); }