From patchwork Mon Mar 9 23:49:27 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: stephen hemminger X-Patchwork-Id: 24235 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id A0AE7DE0FE for ; Tue, 10 Mar 2009 10:49:36 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752187AbZCIXtc (ORCPT ); Mon, 9 Mar 2009 19:49:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752154AbZCIXtb (ORCPT ); Mon, 9 Mar 2009 19:49:31 -0400 Received: from mail.vyatta.com ([76.74.103.46]:38329 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbZCIXtb (ORCPT ); Mon, 9 Mar 2009 19:49:31 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.vyatta.com (Postfix) with ESMTP id 8F6064F4204; Mon, 9 Mar 2009 16:49:32 -0700 (PDT) X-Virus-Scanned: amavisd-new at tahiti.vyatta.com Received: from mail.vyatta.com ([127.0.0.1]) by localhost (mail.vyatta.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vaNPqBI5kewJ; Mon, 9 Mar 2009 16:49:32 -0700 (PDT) Received: from nehalam (pool-71-117-208-104.ptldor.fios.verizon.net [71.117.208.104]) by mail.vyatta.com (Postfix) with ESMTP id 35FFA4F4052; Mon, 9 Mar 2009 16:49:32 -0700 (PDT) Date: Mon, 9 Mar 2009 16:49:27 -0700 From: Stephen Hemminger To: "Gerhard Pircher" Cc: netdev@vger.kernel.org Subject: Re: 3c59x: shared interrupt problem Message-ID: <20090309164927.6eb12aff@nehalam> In-Reply-To: <20090309224253.135220@gmx.net> References: <20090309224253.135220@gmx.net> Organization: Vyatta X-Mailer: Claws Mail 3.6.1 (GTK+ 2.15.5; x86_64-pc-linux-gnu) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 09 Mar 2009 23:42:53 +0100 "Gerhard Pircher" wrote: > Hi! > > Large network transfers fail on my machine (with kernel versions > >v2.6.26) with the kernel oops below. eth0 (3c59x driver) normally > shares its IRQ line with 3 OHCI USB ports (IRQ 7), as the excerpt of > /proc/interrupt shows. Removing USB support from the kernel makes it > work again. I wasn't able to do a full git bisect run yet, as v2.6.27 > didn't produce a bootable kernel image for my machine. The machine is > an AmigaOne PowerPC G4 with an onboard 3c920 network chip. > > Any idea? Does this help, it looks like boomerang_interrupt was not doing shared irq stuff correctly. --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/net/3c59x.c 2009-03-09 16:07:13.372670015 -0700 +++ b/drivers/net/3c59x.c 2009-03-09 16:08:50.214357441 -0700 @@ -2301,6 +2301,7 @@ boomerang_interrupt(int irq, void *dev_i void __iomem *ioaddr; int status; int work_done = max_interrupt_work; + int handled = 0; ioaddr = vp->ioaddr; @@ -2323,6 +2324,7 @@ boomerang_interrupt(int irq, void *dev_i printk(KERN_DEBUG "boomerang_interrupt(1): status = 0xffff\n"); goto handler_exit; } + handled = 1; if (status & IntReq) { status |= vp->deferred; @@ -2417,7 +2419,7 @@ boomerang_interrupt(int irq, void *dev_i dev->name, status); handler_exit: spin_unlock(&vp->lock); - return IRQ_HANDLED; + return IRQ_RETVAL(handled); } static int vortex_rx(struct net_device *dev)