From patchwork Tue May 7 11:34:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Arcangeli X-Patchwork-Id: 242181 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 549C32C017E for ; Tue, 7 May 2013 21:34:56 +1000 (EST) Received: from localhost ([::1]:46162 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZgAY-0008Ii-Cd for incoming@patchwork.ozlabs.org; Tue, 07 May 2013 07:34:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZgAI-0008IZ-55 for qemu-devel@nongnu.org; Tue, 07 May 2013 07:34:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZgAD-0007Jn-H6 for qemu-devel@nongnu.org; Tue, 07 May 2013 07:34:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZgAD-0007Jb-8D for qemu-devel@nongnu.org; Tue, 07 May 2013 07:34:33 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r47BYVqX013940 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 7 May 2013 07:34:31 -0400 Received: from mail.random (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r47BYU2G006603; Tue, 7 May 2013 07:34:30 -0400 Date: Tue, 7 May 2013 13:34:29 +0200 From: Andrea Arcangeli To: Andrew Jones Message-ID: <20130507113429.GB12538@redhat.com> References: <1367870221-12676-1-git-send-email-aarcange@redhat.com> <1367870221-12676-2-git-send-email-aarcange@redhat.com> <20130507111629.GA10720@hawk.usersys.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130507111629.GA10720@hawk.usersys.redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Anthony Liguori , Juan Quintela , Hugh Dickins , qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, Orit Wasserman , Mel Gorman , Paolo Bonzini , Isaku Yamahata Subject: Re: [Qemu-devel] [PATCH 1/4] mm: madvise MADV_USERFAULT X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Hi Andrew, On Tue, May 07, 2013 at 01:16:30PM +0200, Andrew Jones wrote: > On Mon, May 06, 2013 at 09:56:58PM +0200, Andrea Arcangeli wrote: > > @@ -405,6 +420,7 @@ madvise_behavior_valid(int behavior) > > case MADV_HUGEPAGE: > > case MADV_NOHUGEPAGE: > > #endif > > + case MADV_USERFAULT: > > Missing MADV_NOUSERFAULT: here Right, thanks! Folded the below in patch 1/4. diff --git a/mm/madvise.c b/mm/madvise.c index 2ecab73..8828e5c 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -421,6 +421,7 @@ madvise_behavior_valid(int behavior) case MADV_NOHUGEPAGE: #endif case MADV_USERFAULT: + case MADV_NOUSERFAULT: case MADV_DONTDUMP: case MADV_DODUMP: return 1;