From patchwork Tue May 7 08:28:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 242075 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 4E45B2C015E for ; Tue, 7 May 2013 18:29:02 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZdGK-0005Od-MX; Tue, 07 May 2013 08:28:40 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZdGE-0005NZ-Gm for fwts-devel@lists.ubuntu.com; Tue, 07 May 2013 08:28:34 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UZdGE-0008DD-Db for fwts-devel@lists.ubuntu.com; Tue, 07 May 2013 08:28:34 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpica: fwts_acpica: missing unlock on error path Date: Tue, 7 May 2013 09:28:33 +0100 Message-Id: <1367915313-17171-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.1.2 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Coverity CID #997292: Missing unlock Forgot to unlock mutex_lock_sem_table if we cannot find any free semaphores on error path. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Keng-Yu Lin --- src/acpica/fwts_acpica.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c index 85ac735..73bfa73 100644 --- a/src/acpica/fwts_acpica.c +++ b/src/acpica/fwts_acpica.c @@ -509,8 +509,10 @@ ACPI_STATUS AcpiOsCreateSemaphore(UINT32 MaxUnits, } } - if (!sem) + if (!sem) { + pthread_mutex_unlock(&mutex_lock_sem_table); return AE_NO_MEMORY; + } sem->used = true; sem->count = 0;