From patchwork Tue May 7 08:20:12 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 242073 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 897D62C0104 for ; Tue, 7 May 2013 18:20:40 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZd8E-0003vm-KY; Tue, 07 May 2013 08:20:18 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZd89-0003vR-1K for fwts-devel@lists.ubuntu.com; Tue, 07 May 2013 08:20:13 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UZd88-0007vY-Rn for fwts-devel@lists.ubuntu.com; Tue, 07 May 2013 08:20:12 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] lib: fwts_release: check *str rather than str Date: Tue, 7 May 2013 09:20:12 +0100 Message-Id: <1367914812-16805-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.1.2 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Coverity CID #997338: Dereference before null check (REVERSE_NULL) Should be checking if *str is not end of string rather than if str is a valid pointer (typo). Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Keng-Yu Lin --- src/lib/src/fwts_release.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/src/fwts_release.c b/src/lib/src/fwts_release.c index 5c06747..c428856 100644 --- a/src/lib/src/fwts_release.c +++ b/src/lib/src/fwts_release.c @@ -38,7 +38,7 @@ static void fwts_release_field_get(char *needle, char *delimiter, char *text, ch while (*str == ' ') str++; - if (str) + if (*str) *field = strdup(str); }