From patchwork Tue May 7 08:08:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 242068 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 823262C00EC for ; Tue, 7 May 2013 18:08:31 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZcwU-00021x-6W; Tue, 07 May 2013 08:08:10 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZcwO-000218-NG for fwts-devel@lists.ubuntu.com; Tue, 07 May 2013 08:08:04 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UZcwO-0007LG-Jy for fwts-devel@lists.ubuntu.com; Tue, 07 May 2013 08:08:04 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpi: lid: Fix nesting bug Date: Tue, 7 May 2013 09:08:04 +0100 Message-Id: <1367914084-16156-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.1.2 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Coverity CID #997282: Nesting level does not match indentation Nest correctly. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Keng-Yu Lin --- src/acpi/lid/lid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/acpi/lid/lid.c b/src/acpi/lid/lid.c index 9117fc8..65fdc8a 100644 --- a/src/acpi/lid/lid.c +++ b/src/acpi/lid/lid.c @@ -146,7 +146,7 @@ static int lid_test_state(fwts_framework *fw, int button) "Did not detect any ACPI LID events while waiting for to LID %s.", state); fwts_tag_failed(fw, FWTS_TAG_ACPI_LID); fwts_tag_failed(fw, FWTS_TAG_ACPI_EVENT); - } else + } else { fwts_passed(fw, "Detected ACPI LID events while waiting for LID to %s.", state); if ((matching == 0) || (not_matching > 0)) { fwts_failed(fw, LOG_LEVEL_HIGH, "NoLidState", @@ -154,6 +154,7 @@ static int lid_test_state(fwts_framework *fw, int button) fwts_tag_failed(fw, FWTS_TAG_ACPI_LID); } else fwts_passed(fw, "Detected lid %s state.", state); + } return FWTS_OK; }