From patchwork Tue May 7 07:21:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 242051 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 8D0FB2C0129 for ; Tue, 7 May 2013 17:22:56 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZcEM-0003Vj-3R; Tue, 07 May 2013 07:22:34 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZcDn-0003Ta-LG for fwts-devel@lists.ubuntu.com; Tue, 07 May 2013 07:21:59 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UZcDn-0005dI-IE for fwts-devel@lists.ubuntu.com; Tue, 07 May 2013 07:21:59 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpica: fwts_acpica: clear sa_mask fields Date: Tue, 7 May 2013 08:21:59 +0100 Message-Id: <1367911319-21302-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.1.2 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Coverity CID #997325, Uninitialized scalar variable (UNINIT) We should also clear the sa_mask fields. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Keng-Yu Lin --- src/acpica/fwts_acpica.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c index b9c8839..85ac735 100644 --- a/src/acpica/fwts_acpica.c +++ b/src/acpica/fwts_acpica.c @@ -585,6 +585,7 @@ ACPI_STATUS AcpiOsWaitSemaphore(ACPI_HANDLE handle, UINT32 Units, UINT16 Timeout * control to continue. It is evil. */ sa.sa_handler = sem_alarm; + sigemptyset(&sa.sa_mask); sa.sa_flags = 0; sigaction(SIGALRM, &sa, NULL); alarm(MAX_WAIT_TIMEOUT);