[i386] Default alignment for AMD BD and BT

Submitted by Gopalasubramanian, Ganesh on May 7, 2013, 7:16 a.m.

Details

Message ID EB4625145972F94C9680D8CADD651615446C45C5@sausexdag06.amd.com
State New
Headers show

Commit Message

Gopalasubramanian, Ganesh May 7, 2013, 7:16 a.m.
Hi 

The patch updates the alignment values for AMD BD and BT architectures.

"make -k check" passes.

Is it OK for upstream?

Regards
Ganesh

2013-05-07  Ganesh Gopalasubramanian  <Ganesh.Gopalasubramanian@amd.com>

    * config/i386/i386.c (processor_target_table): Modified default 
    alignment values for AMD BD and BT architectures.

Comments

Uros Bizjak May 7, 2013, 12:51 p.m.
On Tue, May 7, 2013 at 9:16 AM, Gopalasubramanian, Ganesh
<Ganesh.Gopalasubramanian@amd.com> wrote:

> The patch updates the alignment values for AMD BD and BT architectures.
>
> "make -k check" passes.
>
> Is it OK for upstream?
>
> 2013-05-07  Ganesh Gopalasubramanian  <Ganesh.Gopalasubramanian@amd.com>
>
>     * config/i386/i386.c (processor_target_table): Modified default
>     alignment values for AMD BD and BT architectures.

The value 11 indeed looks a bit weird, but it means: align to 16 byte
boundary only if this can be done by skipping 10 bytes or less.

Tha patch is OK for mainline.

Thanks,
Uros.
Gopalasubramanian, Ganesh May 13, 2013, 9:37 a.m.
Thank you Uros!

Committed r198820. 

Regards
Ganesh


-----Original Message-----
From: Uros Bizjak [mailto:ubizjak@gmail.com] 
Sent: Tuesday, May 07, 2013 6:22 PM
To: Gopalasubramanian, Ganesh
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH,i386] Default alignment for AMD BD and BT

On Tue, May 7, 2013 at 9:16 AM, Gopalasubramanian, Ganesh <Ganesh.Gopalasubramanian@amd.com> wrote:

> The patch updates the alignment values for AMD BD and BT architectures.
>
> "make -k check" passes.
>
> Is it OK for upstream?
>
> 2013-05-07  Ganesh Gopalasubramanian  
> <Ganesh.Gopalasubramanian@amd.com>
>
>     * config/i386/i386.c (processor_target_table): Modified default
>     alignment values for AMD BD and BT architectures.

The value 11 indeed looks a bit weird, but it means: align to 16 byte boundary only if this can be done by skipping 10 bytes or less.

Tha patch is OK for mainline.

Thanks,
Uros.
Gopalasubramanian, Ganesh May 29, 2013, 11:28 a.m.
Hi

We want this to be backported to GCC48 branch.
Please approve.

Regards
Ganesh

-----Original Message-----
From: Uros Bizjak [mailto:ubizjak@gmail.com] 
Sent: Tuesday, May 07, 2013 6:22 PM
To: Gopalasubramanian, Ganesh
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH,i386] Default alignment for AMD BD and BT

On Tue, May 7, 2013 at 9:16 AM, Gopalasubramanian, Ganesh <Ganesh.Gopalasubramanian@amd.com> wrote:

> The patch updates the alignment values for AMD BD and BT architectures.
>
> "make -k check" passes.
>
> Is it OK for upstream?
>
> 2013-05-07  Ganesh Gopalasubramanian  
> <Ganesh.Gopalasubramanian@amd.com>
>
>     * config/i386/i386.c (processor_target_table): Modified default
>     alignment values for AMD BD and BT architectures.

The value 11 indeed looks a bit weird, but it means: align to 16 byte boundary only if this can be done by skipping 10 bytes or less.

Tha patch is OK for mainline.

Thanks,
Uros.
Uros Bizjak May 30, 2013, 8:09 a.m.
On Wed, May 29, 2013 at 1:28 PM, Gopalasubramanian, Ganesh
<Ganesh.Gopalasubramanian@amd.com> wrote:

> We want this to be backported to GCC48 branch.
> Please approve.
>
> -----Original Message-----
> From: Uros Bizjak [mailto:ubizjak@gmail.com]
> Sent: Tuesday, May 07, 2013 6:22 PM
> To: Gopalasubramanian, Ganesh
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH,i386] Default alignment for AMD BD and BT
>
> On Tue, May 7, 2013 at 9:16 AM, Gopalasubramanian, Ganesh <Ganesh.Gopalasubramanian@amd.com> wrote:
>
>> The patch updates the alignment values for AMD BD and BT architectures.
>>
>> "make -k check" passes.
>>
>> Is it OK for upstream?
>>
>> 2013-05-07  Ganesh Gopalasubramanian
>> <Ganesh.Gopalasubramanian@amd.com>
>>
>>     * config/i386/i386.c (processor_target_table): Modified default
>>     alignment values for AMD BD and BT architectures.

This is OK, but please wait until 4.8 branch is open again.

Thanks,
Uros.

Patch hide | download patch | download mbox

Index: gcc/config/i386/i386.c
===================================================================
--- gcc/config/i386/i386.c      (revision 198386)
+++ gcc/config/i386/i386.c      (working copy)
@@ -2450,11 +2450,11 @@ 
   {&generic32_cost, 16, 7, 16, 7, 16},
   {&generic64_cost, 16, 10, 16, 10, 16},
   {&amdfam10_cost, 32, 24, 32, 7, 32},
-  {&bdver1_cost, 32, 24, 32, 7, 32},
-  {&bdver2_cost, 32, 24, 32, 7, 32},
-  {&bdver3_cost, 32, 24, 32, 7, 32},
-  {&btver1_cost, 32, 24, 32, 7, 32},
-  {&btver2_cost, 32, 24, 32, 7, 32},
+  {&bdver1_cost, 16, 10, 16, 7, 11},
+  {&bdver2_cost, 16, 10, 16, 7, 11},
+  {&bdver3_cost, 16, 10, 16, 7, 11},
+  {&btver1_cost, 16, 10, 16, 7, 11},
+  {&btver2_cost, 16, 10, 16, 7, 11},
   {&atom_cost, 16, 15, 16, 7, 16}
 };