From patchwork Tue May 7 07:03:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 242042 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 29A552C0186 for ; Tue, 7 May 2013 17:04:16 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZbwJ-0000k5-20; Tue, 07 May 2013 07:03:55 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZbwD-0000k0-G6 for fwts-devel@lists.ubuntu.com; Tue, 07 May 2013 07:03:49 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UZbwD-0004wJ-D0 for fwts-devel@lists.ubuntu.com; Tue, 07 May 2013 07:03:49 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] lib: fwts_log: free log_file on error exit Date: Tue, 7 May 2013 08:03:48 +0100 Message-Id: <1367910228-32752-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.1.2 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King overity CID#997342: Resource leak log_file needs to be free'd on log_file->fp == NULL error condition. Signed-off-by: Colin Ian King --- src/lib/src/fwts_log.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/src/fwts_log.c b/src/lib/src/fwts_log.c index 4667a76..41214da 100644 --- a/src/lib/src/fwts_log.c +++ b/src/lib/src/fwts_log.c @@ -674,6 +674,7 @@ fwts_log *fwts_log_open( if (log_file->fp == NULL) { fwts_log_close(newlog); + free(log_file); return NULL; } }