Patchwork [20/26] mtd: nand: omap2: remove unnecessary platform_set_drvdata()

login
register
mail settings
Submitter Jingoo Han
Date May 7, 2013, 6:41 a.m.
Message ID <005801ce4aed$ed90d6c0$c8b28440$@samsung.com>
Download mbox | patch
Permalink /patch/242035/
State Accepted
Commit c15640081b0b89216600c87930a26ca93bc83839
Headers show

Comments

Jingoo Han - May 7, 2013, 6:41 a.m.
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/mtd/nand/omap2.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
pekon gupta - June 5, 2013, 7:01 a.m.
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit
> 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Pekon Gupta <pekon@ti.com>

Thanks for this .. 
With regards, pekon

> ---
>  drivers/mtd/nand/omap2.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 81b80af..daa3dfc 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -2087,7 +2087,6 @@ static int omap_nand_remove(struct
> platform_device *pdev)
>  							mtd);
>  	omap3_free_bch(&info->mtd);
> 
> -	platform_set_drvdata(pdev, NULL);
>  	if (info->dma)
>  		dma_release_channel(info->dma);
> 
> --
> 1.7.2.5
> 
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

Patch

diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 81b80af..daa3dfc 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -2087,7 +2087,6 @@  static int omap_nand_remove(struct platform_device *pdev)
 							mtd);
 	omap3_free_bch(&info->mtd);
 
-	platform_set_drvdata(pdev, NULL);
 	if (info->dma)
 		dma_release_channel(info->dma);