From patchwork Tue May 7 06:39:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 242032 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2D2B82C0126 for ; Tue, 7 May 2013 16:39:45 +1000 (EST) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UZbYq-0000JV-Jc; Tue, 07 May 2013 06:39:40 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UZbYo-0004RI-GG; Tue, 07 May 2013 06:39:38 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UZbYn-0004Qu-AW for linux-mtd@lists.infradead.org; Tue, 07 May 2013 06:39:37 +0000 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMF00J7D14UZ8C0@mailout2.samsung.com> for linux-mtd@lists.infradead.org; Tue, 07 May 2013 15:39:16 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.50]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 5F.BF.19730.491A8815; Tue, 07 May 2013 15:39:16 +0900 (KST) X-AuditID: cbfee68e-b7efa6d000004d12-67-5188a19480f7 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 19.91.01422.391A8815; Tue, 07 May 2013 15:39:16 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MMF00H5D15FLG00@mmp2.samsung.com>; Tue, 07 May 2013 15:39:15 +0900 (KST) From: Jingoo Han To: 'Artem Bityutskiy' Subject: [PATCH 17/26] mtd: nand: lpc32xx: remove unnecessary platform_set_drvdata() Date: Tue, 07 May 2013 15:39:15 +0900 Message-id: <005501ce4aed$981487f0$c83d97d0$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5K7YJedOwFbwOMTD6NxhfNRf8TFw== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsVy+t8zI90pCzsCDS7t4LR48/gZs8XElZOZ LS4vvMRqsbtpGbvF5CVnWR1YPeZM3c3osXmFlse8k4Eem5fUe/RtWcUYwBrFZZOSmpNZllqk b5fAldE8r4ux4C5vxeZjZ1kbGG9xdzFyckgImEgs7b3DBGGLSVy4t56ti5GLQ0hgGaNE9/Op bDBF93fsZ4JITGeUuPhnIjOE84tR4vDnrcwgVWwCahJfvhxm72Lk4BARsJT4MtMXpIZZYAKj xNn9CxhBaoQFwiTWPrsOto5FQFXi5esTLCA2L1D99MOtrBC2oMSPyffA4swCWhLrdx5ngrDl JTavecsMcZGCxI6zr8FmigjoSTzavYAdokZEYt+Ld4wgiyUEjrFLdC3qYoNYJiDxbfIhFpDj JARkJTYdgJojKXFwxQ2WCYxis5CsnoVk9Swkq2chWbGAkWUVo2hqQXJBcVJ6kZFecWJucWle ul5yfu4mRkjk9e1gvHnA+hBjMtD6icxSosn5wMjNK4k3NDYzsjA1MTU2Mrc0I01YSZxXrcU6 UEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVAOjV7nj/OiZ+4J/f6woeedwLvKS7haTtdmuWqZf C7ibmV0M2nflcU1ctfVt/+QV22ocYuTP91hInCgT3bM56/e90smemXV2d4+bHVt8ZyHLmRmz 3X/870/NdA+o2B+sfbtndc3/zs6uE3LTVDWVLSz3LVoyN1Wr/LnaCfaPKrfjLQ7MF+/s0qtS YinOSDTUYi4qTgQAzt/pZ9ICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsVy+t9jQd0pCzsCDWZtYrV48/gZs8XElZOZ LS4vvMRqsbtpGbvF5CVnWR1YPeZM3c3osXmFlse8k4Eem5fUe/RtWcUYwBrVwGiTkZqYklqk kJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7RbSaEsMacUKBSQWFys pG+HaUJoiJuuBUxjhK5vSBBcj5EBGkhYx5jRPK+LseAub8XmY2dZGxhvcXcxcnJICJhI3N+x nwnCFpO4cG89WxcjF4eQwHRGiYt/JjJDOL8YJQ5/3soMUsUmoCbx5cth9i5GDg4RAUuJLzN9 QWqYBSYwSpzdv4ARpEZYIExi7bPrYFNZBFQlXr4+wQJi8wLVTz/cygphC0r8mHwPLM4soCWx fudxJghbXmLzmrfMEBcpSOw4+xpspoiAnsSj3QvYIWpEJPa9eMc4gVFgFpJRs5CMmoVk1Cwk LQsYWVYxiqYWJBcUJ6XnGukVJ+YWl+al6yXn525iBMf1M+kdjKsaLA4xCnAwKvHwKpxqDxRi TSwrrsw9xCjBwawkwiut3REoxJuSWFmVWpQfX1Sak1p8iDEZ6NOJzFKiyfnAlJNXEm9obGJm ZGlkZmFkYm5OmrCSOO/BVutAIYH0xJLU7NTUgtQimC1MHJxSDYwNX+4U7J0rn37n8eTQU+xe 0wuNHP7zu96Q6bm8i6no4S/XK2kTD/h5Po55uCxh0uW73/tEsw+e5hN7Z5j6+V89Xz3jj9SJ zpZaCXOlr7Ko8C0R79exVMsJCpvoterdqoBAmeuP+N3uuApksst5bt843diiTc722Xaz1/ee lu9yVf6xr3ZN0wslluKMREMt5qLiRABwu5UtLwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130507_023937_590902_58A95F0B X-CRM114-Status: UNSURE ( 8.72 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -8.1 (--------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-8.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.25 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.2 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 T_HDRS_LCASE Odd capitalization of message header 0.0 T_MANY_HDRS_LCASE Odd capitalization of multiple message headers Cc: Roland Stigge , linux-mtd@lists.infradead.org, Jingoo Han , 'David Woodhouse' X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han Tested-by: Roland Stigge Acked-by: Roland Stigge --- drivers/mtd/nand/lpc32xx_mlc.c | 2 -- drivers/mtd/nand/lpc32xx_slc.c | 2 -- 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/lpc32xx_mlc.c b/drivers/mtd/nand/lpc32xx_mlc.c index a94facb..5a5cfbc 100644 --- a/drivers/mtd/nand/lpc32xx_mlc.c +++ b/drivers/mtd/nand/lpc32xx_mlc.c @@ -833,7 +833,6 @@ err_exit3: err_exit2: clk_disable(host->clk); clk_put(host->clk); - platform_set_drvdata(pdev, NULL); err_exit1: lpc32xx_wp_enable(host); gpio_free(host->ncfg->wp_gpio); @@ -856,7 +855,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev) clk_disable(host->clk); clk_put(host->clk); - platform_set_drvdata(pdev, NULL); lpc32xx_wp_enable(host); gpio_free(host->ncfg->wp_gpio); diff --git a/drivers/mtd/nand/lpc32xx_slc.c b/drivers/mtd/nand/lpc32xx_slc.c index be94ed5..a66f33f 100644 --- a/drivers/mtd/nand/lpc32xx_slc.c +++ b/drivers/mtd/nand/lpc32xx_slc.c @@ -936,7 +936,6 @@ err_exit3: err_exit2: clk_disable(host->clk); clk_put(host->clk); - platform_set_drvdata(pdev, NULL); err_exit1: lpc32xx_wp_enable(host); gpio_free(host->ncfg->wp_gpio); @@ -963,7 +962,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev) clk_disable(host->clk); clk_put(host->clk); - platform_set_drvdata(pdev, NULL); lpc32xx_wp_enable(host); gpio_free(host->ncfg->wp_gpio);