From patchwork Tue May 7 06:34:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 242028 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 831D32C00AD for ; Tue, 7 May 2013 16:35:19 +1000 (EST) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UZbUY-0007Yd-Ti; Tue, 07 May 2013 06:35:15 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UZbUW-0004LC-Vl; Tue, 07 May 2013 06:35:12 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UZbUU-0004KS-KX for linux-mtd@lists.infradead.org; Tue, 07 May 2013 06:35:11 +0000 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMF00DBM0XP02A0@mailout3.samsung.com> for linux-mtd@lists.infradead.org; Tue, 07 May 2013 15:34:48 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 63.9C.31024.880A8815; Tue, 07 May 2013 15:34:48 +0900 (KST) X-AuditID: cbfee68d-b7f016d000007930-13-5188a08803fe Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id DF.30.01422.880A8815; Tue, 07 May 2013 15:34:48 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MMF001UC0Y0SDG1@mmp1.samsung.com>; Tue, 07 May 2013 15:34:48 +0900 (KST) From: Jingoo Han To: 'Artem Bityutskiy' Subject: [PATCH 13/26] mtd: nand: docg4: remove unnecessary platform_set_drvdata() Date: Tue, 07 May 2013 15:34:48 +0900 Message-id: <005101ce4aec$f89a6b90$e9cf42b0$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5K7OloDqWm1WmgTluE8d2GycWD+Q== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsVy+t8zQ92OBR2BBpMPGFm8efyM2WLiysnM FpcXXmK12N20jN1i7aufbA6sHptXaHnMOxnosXlJvceS6+9ZPfq2rGIMYI3isklJzcksSy3S t0vgyji54SFLwRrOirY5c1gaGB+zdzFyckgImEgsbF4LZYtJXLi3nq2LkYtDSGAZo8SM98tY YYq+zdzNCJFYxCjReO0FM4Tzi1Fi8YZTYO1sAmoSX74cBrI5OEQELCW+zPQFqWEWmMQosaPl MtgkYYEQiYsPJjCD2CwCqhJn7xwCi/MC1V+bcR/KFpT4MfkeC4jNLKAlsX7ncSYIW15i85q3 zBAXKUjsOPuaEcQWEdCTuHj5N1SNiMS+F+/ALpUQOMQu8XrSeqhlAhLfJh9iATlOQkBWYtMB qDmSEgdX3GCZwCg2C8nqWUhWz0KyehaSFQsYWVYxiqYWJBcUJ6UXGeoVJ+YWl+al6yXn525i hERe7w7G2wesDzEmA62fyCwlmpwPjNy8knhDYzMjC1MTU2Mjc0sz0oSVxHnVWqwDhQTSE0tS s1NTC1KL4otKc1KLDzEycXBKNTAqL3mwzOj8TcETWWntp1LK1j020J3uWm6sP3PC888nklS6 5PrmcLb6f3n9KubM+w2XbK9efzvtxUzprG4pq7XCVkIiQueqs7zPzUu6oP7uhPLmqC/8s27E vA3a0Lxp+WVuMTfXstvT92c7Jvrd5WD61bV+l3/l6YCVD0ReLMvap56pe+BG71MXJZbijERD Leai4kQAP6xOqNICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsVy+t9jAd2OBR2BBs+f61m8efyM2WLiysnM FpcXXmK12N20jN1i7aufbA6sHptXaHnMOxnosXlJvceS6+9ZPfq2rGIMYI1qYLTJSE1MSS1S SM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMAdqtpFCWmFMKFApILC5W 0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsY8w4ueEhS8Eazoq2OXNYGhgfs3cxcnJICJhIfJu5 mxHCFpO4cG89WxcjF4eQwCJGicZrL5ghnF+MEos3nALrYBNQk/jy5TCQzcEhImAp8WWmL0gN s8AkRokdLZdZQWqEBUIkLj6YwAxiswioSpy9cwgszgtUf23GfShbUOLH5HssIDazgJbE+p3H mSBseYnNa94yQ1ykILHj7Guw60QE9CQuXv4NVSMise/FO8YJjAKzkIyahWTULCSjZiFpWcDI sopRNLUguaA4KT3XSK84Mbe4NC9dLzk/dxMjOK6fSe9gXNVgcYhRgINRiYdX4VR7oBBrYllx Ze4hRgkOZiURXmntjkAh3pTEyqrUovz4otKc1OJDjMlAn05klhJNzgemnLySeENjEzMjSyMz CyMTc3PShJXEeQ+2WgcKCaQnlqRmp6YWpBbBbGHi4JRqYOzJPbCwv/v2ZLngqwGG8+rDX0vO W8h7vf7R332FD/VmfIxi/r5tuapO9Eb1cDX9eWWZsvWa+Yy8bE+rVl4tqUlv2LvUb27h681M fXV5tZHnSu6t/bBh6+2OKm5ZYc1vb09LLlB8yZ8SdWLC78m/z67fceJJ2LII5ymvQt7JaNYx HYqfYXhEQkaJpTgj0VCLuag4EQCYTYfZLwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130507_023510_908779_941699B2 X-CRM114-Status: GOOD ( 10.20 ) X-Spam-Score: -8.1 (--------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-8.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.33 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.2 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 T_HDRS_LCASE Odd capitalization of message header 0.0 T_MANY_HDRS_LCASE Odd capitalization of multiple message headers Cc: linux-mtd@lists.infradead.org, Jingoo Han , 'David Woodhouse' , 'Mike Dunn' X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han Acked-by: Mike Dunn --- drivers/mtd/nand/docg4.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/docg4.c b/drivers/mtd/nand/docg4.c index fa25e7a..dc86d4a 100644 --- a/drivers/mtd/nand/docg4.c +++ b/drivers/mtd/nand/docg4.c @@ -1368,7 +1368,6 @@ static int __init probe_docg4(struct platform_device *pdev) struct nand_chip *nand = mtd->priv; struct docg4_priv *doc = nand->priv; nand_release(mtd); /* deletes partitions and mtd devices */ - platform_set_drvdata(pdev, NULL); free_bch(doc->bch); kfree(mtd); } @@ -1380,7 +1379,6 @@ static int __exit cleanup_docg4(struct platform_device *pdev) { struct docg4_priv *doc = platform_get_drvdata(pdev); nand_release(doc->mtd); - platform_set_drvdata(pdev, NULL); free_bch(doc->bch); kfree(doc->mtd); iounmap(doc->virtadr);