From patchwork Tue May 7 06:25:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 242009 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 231CA2C0142 for ; Tue, 7 May 2013 16:26:32 +1000 (EST) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UZbM0-00047s-PL; Tue, 07 May 2013 06:26:25 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UZbLy-00041a-Se; Tue, 07 May 2013 06:26:22 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UZbLv-00040z-Vn for linux-mtd@lists.infradead.org; Tue, 07 May 2013 06:26:20 +0000 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMF00E7L0J9ZIE0@mailout2.samsung.com> for linux-mtd@lists.infradead.org; Tue, 07 May 2013 15:25:57 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.50]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id AA.FA.04074.57E98815; Tue, 07 May 2013 15:25:57 +0900 (KST) X-AuditID: cbfee690-b7f136d000000fea-c3-51889e75378b Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 33.9D.01422.57E98815; Tue, 07 May 2013 15:25:57 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MMF00DUN0J9L0H0@mmp2.samsung.com>; Tue, 07 May 2013 15:25:57 +0900 (KST) From: Jingoo Han To: 'Artem Bityutskiy' References: In-reply-to: Subject: [PATCH 01/26] mtd: devices: spear_smi: remove unnecessary platform_set_drvdata() Date: Tue, 07 May 2013 15:25:57 +0900 Message-id: <004501ce4aeb$bc1006e0$343014a0$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5K6oHGJA1ABuyqSXClZLbhdGk6ZAAAQXsA Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKIsWRmVeSWpSXmKPExsVy+t8zI93SeR2BBotnKVm8efyM2WLiysnM FpcXXmK12N20jN1i41cPB1aPzSu0PO5c28PmMe9koMfmJfUefVtWMQawRnHZpKTmZJalFunb JXBl7L99l6XgAGfF3hcL2RoYn7F3MXJySAiYSHQdn8oMYYtJXLi3nq2LkYtDSGAZo8T1J9dZ YIpmvznMCpGYzijRdOwSVNUvRomLK7+AVbEJqEl8+XIYaCwHh4iApcSXmb4gNcwC0xgllk6Y wQoSFxLglljdHARSzinAI7HuTyfYZmGBaIme/vVgNouAqsTOtvNgNi/QmFOzXjBC2IISPybf A1vFLKAlsX7ncSYIW15i85q3UB8oSOw4+xqsXkTASOL4vC42iBoRiX0v3jGC3CMhcItd4vvO q2wQywQkvk0+xAJym4SArMSmA1BzJCUOrrjBMoFRYhaS1bOQrJ6FZPUsJCsWMLKsYhRNLUgu KE5KLzLRK07MLS7NS9dLzs/dxAiJ0gk7GO8dsD7EmAy0fiKzlGhyPjDK80riDY3NjCxMTUyN jcwtzUgTVhLnVW+xDhQSSE8sSc1OTS1ILYovKs1JLT7EyMTBKdXAqO5wdb9agq2GX4RCMG/Y 37ceklwx/fUBOiEN7reFmL+9imubqZf1fO7UYLZp/28u2BH8KpfVcvp6mxcyv7t+qefFhcY3 VbdzpB2qTRQ4eDEiR2t/k/F1M45VV0ufLxVadH8Dl9ej3ysZmz9VVteabhO+d7DV/QrrxqY5 PCGK3bUtn/5tEZivxFKckWioxVxUnAgA/8p7O+gCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEKsWRmVeSWpSXmKPExsVy+t9jQd3SeR2BBo82yVm8efyM2WLiysnM FpcXXmK12N20jN1i41cPB1aPzSu0PO5c28PmMe9koMfmJfUefVtWMQawRjUw2mSkJqakFimk 5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYArVZSKEvMKQUKBSQWFyvp 22GaEBripmsB0xih6xsSBNdjZIAGEtYxZuy/fZel4ABnxd4XC9kaGJ+xdzFyckgImEjMfnOY FcIWk7hwbz1bFyMXh5DAdEaJpmOXoJxfjBIXV35hAaliE1CT+PLlMFA3B4eIgKXEl5m+IDXM AtMYJZZOmMEKEhcS4JZY3RwEUs4pwCOx7k8nM4gtLBAt0dO/HsxmEVCV2Nl2HszmBRpzatYL RghbUOLH5Htgq5gFtCTW7zzOBGHLS2xe85YZ4lAFiR1nX4PViwgYSRyf18UGUSMise/FO8YJ jEKzkIyahWTULCSjZiFpWcDIsopRNLUguaA4KT3XSK84Mbe4NC9dLzk/dxMjOAU8k97BuKrB 4hCjAAejEg+vwqn2QCHWxLLiytxDjBIczEoivNLaHYFCvCmJlVWpRfnxRaU5qcWHGJOBPp3I LCWanA9MT3kl8YbGJmZGlkZmFkYm5uakCSuJ8x5stQ4UEkhPLEnNTk0tSC2C2cLEwSnVwJgW IXr976GDvLPTA/96LE67z7By75Mdf5k0px15soIpwpgtMXaafL94asfhmIPTp138Lxmf1SF6 0eZr/fWwiCfy/loJIe/EXr8vLXVaM1vpWkLvnTuL2trM7P0E7Vu2nsicv222oqN1ifx7LZ8l TUK5Z+q3rxFq1l3ZnHn7dmfA9puHLn98xKzEUpyRaKjFXFScCAC3QeLqRQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130507_022620_253515_135E3398 X-CRM114-Status: UNSURE ( 8.56 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -8.1 (--------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-8.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.25 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.2 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-mtd@lists.infradead.org, Jingoo Han , 'David Woodhouse' , Viresh Kumar X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han Acked-by: Viresh Kumar --- drivers/mtd/devices/spear_smi.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/devices/spear_smi.c b/drivers/mtd/devices/spear_smi.c index 8a82b8b..e290ef8 100644 --- a/drivers/mtd/devices/spear_smi.c +++ b/drivers/mtd/devices/spear_smi.c @@ -995,14 +995,12 @@ static int spear_smi_probe(struct platform_device *pdev) ret = spear_smi_setup_banks(pdev, i, pdata->np[i]); if (ret) { dev_err(&dev->pdev->dev, "bank setup failed\n"); - goto err_bank_setup; + goto err_irq; } } return 0; -err_bank_setup: - platform_set_drvdata(pdev, NULL); err_irq: clk_disable_unprepare(dev->clk); err: @@ -1040,7 +1038,6 @@ static int spear_smi_remove(struct platform_device *pdev) } clk_disable_unprepare(dev->clk); - platform_set_drvdata(pdev, NULL); return 0; }