Patchwork acpica: fix the build error after patch the update to ACPICA version 20130418

login
register
mail settings
Submitter Ivan Hu
Date May 7, 2013, 6:13 a.m.
Message ID <1367907194-13215-1-git-send-email-ivan.hu@canonical.com>
Download mbox | patch
Permalink /patch/241992/
State Accepted
Headers show

Comments

Ivan Hu - May 7, 2013, 6:13 a.m.
Got the build error after applying the [PATCH] acpica: update to ACPICA version 20130418.
../src/acpica /home/ivanhu/work/temp/temp/fwts/src/acpica/.libs/libfwtsacpica.so -Wl,-rpath -Wl,/usr/lib/fwts
/home/ivanhu/work/temp/temp/fwts/src/acpica/.libs/libfwtsacpica.so: undefined reference to `clock_gettime'
collect2: ld returned 1 exit status
make[3]: *** [fwts] Error 1
make[3]: Leaving directory `/home/work/temp/temp/fwts/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/work/temp/temp/fwts/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/work/temp/temp/fwts'
make: *** [all] Error 2

Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
---
 src/acpica/Makefile.am |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Colin King - May 7, 2013, 6:32 a.m.
On 07/05/13 07:13, Ivan Hu wrote:
> Got the build error after applying the [PATCH] acpica: update to ACPICA version 20130418.
> ../src/acpica /home/ivanhu/work/temp/temp/fwts/src/acpica/.libs/libfwtsacpica.so -Wl,-rpath -Wl,/usr/lib/fwts
> /home/ivanhu/work/temp/temp/fwts/src/acpica/.libs/libfwtsacpica.so: undefined reference to `clock_gettime'
> collect2: ld returned 1 exit status
> make[3]: *** [fwts] Error 1
> make[3]: Leaving directory `/home/work/temp/temp/fwts/src'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/home/work/temp/temp/fwts/src'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/home/work/temp/temp/fwts'
> make: *** [all] Error 2
> 
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>  src/acpica/Makefile.am |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/acpica/Makefile.am b/src/acpica/Makefile.am
> index 1cf8c15..a6123ab 100644
> --- a/src/acpica/Makefile.am
> +++ b/src/acpica/Makefile.am
> @@ -240,5 +240,5 @@ libfwtsacpica_la_SOURCES =			\
>  	$(ACPICA_SRC)/tools/acpiexec/aehandlers.c
>  
>  libfwtsacpica_la_LIBADD = \
> -	-L$(top_srcdir)/src/lib/src -lfwts
> +	-L$(top_srcdir)/src/lib/src -lfwts -lrt
>  
> 

I'm not seeing the need for this on Raring and Saucy.  What release and
architecture are you seeing this failure on?

Colin
Ivan Hu - May 7, 2013, 7:03 a.m.
On 05/07/2013 02:32 PM, Colin Ian King wrote:
> On 07/05/13 07:13, Ivan Hu wrote:
>> Got the build error after applying the [PATCH] acpica: update to ACPICA version 20130418.
>> ../src/acpica /home/ivanhu/work/temp/temp/fwts/src/acpica/.libs/libfwtsacpica.so -Wl,-rpath -Wl,/usr/lib/fwts
>> /home/ivanhu/work/temp/temp/fwts/src/acpica/.libs/libfwtsacpica.so: undefined reference to `clock_gettime'
>> collect2: ld returned 1 exit status
>> make[3]: *** [fwts] Error 1
>> make[3]: Leaving directory `/home/work/temp/temp/fwts/src'
>> make[2]: *** [all-recursive] Error 1
>> make[2]: Leaving directory `/home/work/temp/temp/fwts/src'
>> make[1]: *** [all-recursive] Error 1
>> make[1]: Leaving directory `/home/work/temp/temp/fwts'
>> make: *** [all] Error 2
>>
>> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
>> ---
>>   src/acpica/Makefile.am |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/acpica/Makefile.am b/src/acpica/Makefile.am
>> index 1cf8c15..a6123ab 100644
>> --- a/src/acpica/Makefile.am
>> +++ b/src/acpica/Makefile.am
>> @@ -240,5 +240,5 @@ libfwtsacpica_la_SOURCES =			\
>>   	$(ACPICA_SRC)/tools/acpiexec/aehandlers.c
>>
>>   libfwtsacpica_la_LIBADD = \
>> -	-L$(top_srcdir)/src/lib/src -lfwts
>> +	-L$(top_srcdir)/src/lib/src -lfwts -lrt
>>
>>
>
> I'm not seeing the need for this on Raring and Saucy.  What release and
> architecture are you seeing this failure on?
>
> Colin
>

Precise, 12.04.2 LTS.

Ivan
Colin King - May 7, 2013, 7:55 a.m.
On 07/05/13 07:13, Ivan Hu wrote:
> Got the build error after applying the [PATCH] acpica: update to ACPICA version 20130418.
> ../src/acpica /home/ivanhu/work/temp/temp/fwts/src/acpica/.libs/libfwtsacpica.so -Wl,-rpath -Wl,/usr/lib/fwts
> /home/ivanhu/work/temp/temp/fwts/src/acpica/.libs/libfwtsacpica.so: undefined reference to `clock_gettime'
> collect2: ld returned 1 exit status
> make[3]: *** [fwts] Error 1
> make[3]: Leaving directory `/home/work/temp/temp/fwts/src'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/home/work/temp/temp/fwts/src'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/home/work/temp/temp/fwts'
> make: *** [all] Error 2
> 
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>  src/acpica/Makefile.am |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/acpica/Makefile.am b/src/acpica/Makefile.am
> index 1cf8c15..a6123ab 100644
> --- a/src/acpica/Makefile.am
> +++ b/src/acpica/Makefile.am
> @@ -240,5 +240,5 @@ libfwtsacpica_la_SOURCES =			\
>  	$(ACPICA_SRC)/tools/acpiexec/aehandlers.c
>  
>  libfwtsacpica_la_LIBADD = \
> -	-L$(top_srcdir)/src/lib/src -lfwts
> +	-L$(top_srcdir)/src/lib/src -lfwts -lrt
>  
> 
Thanks for spotting this, it seems that newer releases don't hit this
problem.  It is required for older releases such as Lucid.

Acked-by: Colin Ian King <colin.king@canonical.com>
Alex Hung - May 8, 2013, 1:48 a.m.
On 05/07/2013 02:13 PM, Ivan Hu wrote:
> Got the build error after applying the [PATCH] acpica: update to ACPICA version 20130418.
> ../src/acpica /home/ivanhu/work/temp/temp/fwts/src/acpica/.libs/libfwtsacpica.so -Wl,-rpath -Wl,/usr/lib/fwts
> /home/ivanhu/work/temp/temp/fwts/src/acpica/.libs/libfwtsacpica.so: undefined reference to `clock_gettime'
> collect2: ld returned 1 exit status
> make[3]: *** [fwts] Error 1
> make[3]: Leaving directory `/home/work/temp/temp/fwts/src'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/home/work/temp/temp/fwts/src'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/home/work/temp/temp/fwts'
> make: *** [all] Error 2
>
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>   src/acpica/Makefile.am |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpica/Makefile.am b/src/acpica/Makefile.am
> index 1cf8c15..a6123ab 100644
> --- a/src/acpica/Makefile.am
> +++ b/src/acpica/Makefile.am
> @@ -240,5 +240,5 @@ libfwtsacpica_la_SOURCES =			\
>   	$(ACPICA_SRC)/tools/acpiexec/aehandlers.c
>
>   libfwtsacpica_la_LIBADD = \
> -	-L$(top_srcdir)/src/lib/src -lfwts
> +	-L$(top_srcdir)/src/lib/src -lfwts -lrt
>
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/src/acpica/Makefile.am b/src/acpica/Makefile.am
index 1cf8c15..a6123ab 100644
--- a/src/acpica/Makefile.am
+++ b/src/acpica/Makefile.am
@@ -240,5 +240,5 @@  libfwtsacpica_la_SOURCES =			\
 	$(ACPICA_SRC)/tools/acpiexec/aehandlers.c
 
 libfwtsacpica_la_LIBADD = \
-	-L$(top_srcdir)/src/lib/src -lfwts
+	-L$(top_srcdir)/src/lib/src -lfwts -lrt