Patchwork [v3,2/9] net: sh-eth: Add comment to bit of EDSR about SH7757

login
register
mail settings
Submitter Nobuhiro Iwamatsu
Date May 7, 2013, 5:17 a.m.
Message ID <1367903875-32606-2-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
Download mbox | patch
Permalink /patch/241967/
State Deferred
Delegated to: David Miller
Headers show

Comments

Nobuhiro Iwamatsu - May 7, 2013, 5:17 a.m.
SH7757 uses EDSR register. This adds about SH7757.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
 drivers/net/ethernet/renesas/sh_eth.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Sergei Shtylyov - May 7, 2013, 2:48 p.m.
On 07-05-2013 9:17, Nobuhiro Iwamatsu wrote:

> SH7757 uses EDSR register. This adds about SH7757.

> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
>   drivers/net/ethernet/renesas/sh_eth.h |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/net/ethernet/renesas/sh_eth.h b/drivers/net/ethernet/renesas/sh_eth.h
> index 7ccf58c..71c5559 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.h
> +++ b/drivers/net/ethernet/renesas/sh_eth.h
> @@ -166,7 +166,7 @@ enum {
>   /*
>    * Register's bits
>    */
> -/* EDSR : sh7734, sh7763 and r8a7740 only */
> +/* EDSR : sh7734, sh7763, sh7757 and r8a7740 only */

     Shouldn't SH7763 come after SH7757?

>   enum EDSR_BIT {
>   	EDSR_ENT = 0x01, EDSR_ENR = 0x02,
>   };

    I think you can merge it to patch #1 with a corresponding comment in 
the changelog. This is hardly worth separate patch.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/renesas/sh_eth.h b/drivers/net/ethernet/renesas/sh_eth.h
index 7ccf58c..71c5559 100644
--- a/drivers/net/ethernet/renesas/sh_eth.h
+++ b/drivers/net/ethernet/renesas/sh_eth.h
@@ -166,7 +166,7 @@  enum {
 /*
  * Register's bits
  */
-/* EDSR : sh7734, sh7763 and r8a7740 only */
+/* EDSR : sh7734, sh7763, sh7757 and r8a7740 only */
 enum EDSR_BIT {
 	EDSR_ENT = 0x01, EDSR_ENR = 0x02,
 };