From patchwork Tue May 7 05:02:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241959 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9C78B2C00FD for ; Tue, 7 May 2013 15:02:53 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756603Ab3EGFCu (ORCPT ); Tue, 7 May 2013 01:02:50 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:49154 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756274Ab3EGFCt (ORCPT ); Tue, 7 May 2013 01:02:49 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MME00DU4WOE5V50@mailout3.samsung.com> for netdev@vger.kernel.org; Tue, 07 May 2013 14:02:48 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 80.FF.19730.8FA88815; Tue, 07 May 2013 14:02:48 +0900 (KST) X-AuditID: cbfee68e-b7efa6d000004d12-53-51888af8661c Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id C1.86.08957.8FA88815; Tue, 07 May 2013 14:02:48 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MME00CGIWOOCD40@mmp2.samsung.com>; Tue, 07 May 2013 14:02:48 +0900 (KST) From: Jingoo Han To: "'David S. Miller'" Cc: netdev@vger.kernel.org, Jingoo Han , 'Krzysztof Halasa' Subject: [PATCH 33/36] net: wan: ixp4xx: remove unnecessary platform_set_drvdata() Date: Tue, 07 May 2013 14:02:48 +0900 Message-id: <003201ce4ae0$1e471df0$5ad559d0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5K3/ZM6XkiTwbaQiG9nHULhQLuMg== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMIsWRmVeSWpSXmKPExsVy+t8zA90fXR2BBqtbpS3mnG9hsbi88BKr xdn+00wWxxaIObB4bFl5k8nj/4t/TB59W1YxenzeJBfAEsVlk5Kak1mWWqRvl8CV8WvdW5aC l2wV3xvWszUwPmDtYuTkkBAwkbh/ZA0LhC0mceHeejYQW0hgGaPE4aP5MDXH3/5hgohPZ5R4 8D+vi5ELyP7FKHH930ewZjYBNYkvXw6zdzFycIgI6ErMv24CEmYWSJKYev8D2C5hgRCJpvOH GEFsFgFViTe/W8HivAKWEv82L2CGsAUlfky+xwLRqyWxfudxJghbXmLzmrfMEPcoSOw4+xps joiAnsT/VS+YIWpEJPa9eMcIcpuEwDZ2iQnPj0MtE5D4NvkQC8htEgKyEpsOQM2RlDi44gbL BEaxWUhWz0KyehaS1bOQrFjAyLKKUTS1ILmgOCm9yEivODG3uDQvXS85P3cTIyTC+nYw3jxg fYgxGWj9RGYp0eR8YITmlcQbGpsZWZiamBobmVuakSasJM6r1mIdKCSQnliSmp2aWpBaFF9U mpNafIiRiYNTqoHRoXvteocHFYcS5UUW79x7v4i1TKBjOUcog8ab2k5h+znnyhnuC206x52m 7xFgdNWqU8ZxzaJdCixvHaamz+Q3tPr9ehOHUL7a706eb9YshfEpvPtVpa0FvCYsr4nzyFJ3 +R+VMiWEeZvyDBG92tXVOddOLp047++b2WVXHug+Y7f7+l9CbpoSS3FGoqEWc1FxIgBNpczF xgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIKsWRmVeSWpSXmKPExsVy+t9jQd0fXR2BBr8Oi1vMOd/CYnF54SVW i7P9p5ksji0Qc2Dx2LLyJpPH/xf/mDz6tqxi9Pi8SS6AJaqB0SYjNTEltUghNS85PyUzL91W yTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaKWSQlliTilQKCCxuFhJ3w7ThNAQN10L mMYIXd+QILgeIwM0kLCOMePXurcsBS/ZKr43rGdrYHzA2sXIySEhYCJx/O0fJghbTOLCvfVs ILaQwHRGiQf/87oYuYDsX4wS1/99ZAFJsAmoSXz5cpi9i5GDQ0RAV2L+dROQMLNAksTU+x/A ZgoLhEg0nT/ECGKzCKhKvPndChbnFbCU+Ld5ATOELSjxY/I9FoheLYn1O48zQdjyEpvXvGWG uEdBYsfZ12BzRAT0JP6vesEMUSMise/FO8YJjAKzkIyahWTULCSjZiFpWcDIsopRNLUguaA4 KT3XUK84Mbe4NC9dLzk/dxMjOIKfSe1gXNlgcYhRgINRiYdX4VR7oBBrYllxZe4hRgkOZiUR XmntjkAh3pTEyqrUovz4otKc1OJDjMlAn05klhJNzgcml7ySeENjEzMjSyMzCyMTc3PShJXE eQ+0WgcKCaQnlqRmp6YWpBbBbGHi4JRqYCzeyLx1VYf8FN2F08sWXH+v1hXx4ExavP7xt9vf aLU/CrModvJmu/BcQm+ZxqTrtybdWqu+5tP/+MfeK5+/36cyad7Zw3/EsgV2SXUVPQhQ6JQL fWn77k//cfWZLx14YxoKs3vDec3WtNs7rmGV+v5nidkPo1N+LuUn7nufvHL0imum06RftmlK LMUZiYZazEXFiQBR7gxmJAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/net/wan/ixp4xx_hss.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c index fc9d11d..e7bbdb7 100644 --- a/drivers/net/wan/ixp4xx_hss.c +++ b/drivers/net/wan/ixp4xx_hss.c @@ -1384,7 +1384,6 @@ static int hss_remove_one(struct platform_device *pdev) unregister_hdlc_device(port->netdev); free_netdev(port->netdev); npe_release(port->npe); - platform_set_drvdata(pdev, NULL); kfree(port); return 0; }