From patchwork Tue May 7 05:01:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241957 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D82732C0132 for ; Tue, 7 May 2013 15:01:26 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756264Ab3EGFBX (ORCPT ); Tue, 7 May 2013 01:01:23 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:48931 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754175Ab3EGFBW (ORCPT ); Tue, 7 May 2013 01:01:22 -0400 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MME00DF0WM20250@mailout3.samsung.com> for netdev@vger.kernel.org; Tue, 07 May 2013 14:01:21 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.47]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 54.BE.04074.1AA88815; Tue, 07 May 2013 14:01:21 +0900 (KST) X-AuditID: cbfee690-b7f136d000000fea-23-51888aa11423 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 64.54.01422.0AA88815; Tue, 07 May 2013 14:01:21 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MME00B14WM8AH80@mmp2.samsung.com>; Tue, 07 May 2013 14:01:20 +0900 (KST) From: Jingoo Han To: "'David S. Miller'" Cc: netdev@vger.kernel.org, Jingoo Han , 'Jiri Slaby' , 'Nick Kossifidis' , "'Luis R. Rodriguez'" , 'Jouni Malinen' , 'Vasanthakumar Thiagarajan' , 'Senthil Balasubramanian' Subject: [PATCH 32/36] net: wireless: ath: remove unnecessary platform_set_drvdata() Date: Tue, 07 May 2013 14:01:20 +0900 Message-id: <003101ce4adf$ea309d20$be91d760$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5K34/z1C5W2/EhSVOo41AvWMttSw== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAIsWRmVeSWpSXmKPExsVy+t8zfd2FXR2BBv2PWSzmnG9hsbi88BKr xbsTR1kt/i8ytGg48oLdYvWFnawWxxaIWez9uofJYtXcL0wOnB5bVt5k8tg56y67x6EPR1g9 +rasYvT4vEkugDWKyyYlNSezLLVI3y6BK+PhrTXsBU95K758X8jSwHiCu4uRk0NCwETiyMWb jBC2mMSFe+vZuhi5OIQEljFKPHz7lxmmaEL3K0aIxHRGiTUr7rJAOL8YJb4fb2YDqWITUJP4 8uUwexcjB4eIgK7E/OsmIDXMAveYJLY8BBnLwSEsECYx96o0iMkioCoxdbU+iMkrYCkx/yMf yBBeAUGJH5PvsYDYzAJaEut3HmeCsOUlNq95C3WOgsSOs6/BbhYR0JOYtfw2M0SNiMS+F+/A zpQQeMQusfRPJ1iCRUBA4tvkQywguyQEZCU2HYCaIylxcMUNlgmMYrOQrJ6FZPUsJKtnIVmx gJFlFaNoakFyQXFSepGJXnFibnFpXrpecn7uJkZIbE7YwXjvgPUhxmSg9ROZpUST84GxnVcS b2hsZmRhamJqbGRuaUaasJI4r3qLdaCQQHpiSWp2ampBalF8UWlOavEhRiYOTqkGxihVhzWt 0hc+Wc38cEmJ/aDosx8p1koT7K8d9v8zeS/j2zKpPc/03j3atHQ6s8hB0YC75fqlbhfqm9b/ U3vq4nW8s8MwI9VzP4vPhqc695f3RBzwKj/PksNke+iHgLi5ftl7O5bm6St2SptEL+XbF6Ok l+LQVCeYYpfyueXnXr29e7OFWTVVlViKMxINtZiLihMBsMDdP+MCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDKsWRmVeSWpSXmKPExsVy+t9jQd2FXR2BBhO0Leacb2GxuLzwEqvF uxNHWS3+LzK0aDjygt1i9YWdrBbHFohZ7P26h8li1dwvTA6cHltW3mTy2DnrLrvHoQ9HWD36 tqxi9Pi8SS6ANaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnF J0DXLTMH6BwlhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGEdY8bDW2vYC57y Vnz5vpClgfEEdxcjJ4eEgInEhO5XjBC2mMSFe+vZuhi5OIQEpjNKrFlxlwXC+cUo8f14MxtI FZuAmsSXL4fZuxg5OEQEdCXmXzcBqWEWuMckseUhSDcHh7BAmMTcq9IgJouAqsTU1fogJq+A pcT8j3wgQ3gFBCV+TL7HAmIzC2hJrN95nAnClpfYvOYtM8Q5ChI7zr4GO01EQE9i1vLbzBA1 IhL7XrxjnMAoMAvJqFlIRs1CMmoWkpYFjCyrGEVTC5ILipPSc430ihNzi0vz0vWS83M3MYLj /pn0DsZVDRaHGAU4GJV4eBVOtQcKsSaWFVfmHmKU4GBWEuGV1u4IFOJNSaysSi3Kjy8qzUkt PsSYDPTnRGYp0eR8YErKK4k3NDYxM7I0MrMwMjE3J01YSZz3YKt1oJBAemJJanZqakFqEcwW Jg5OqQbGuq4Tlo/Z4/l25c5TFj37va5rTwrLr+VPFFtLxBcvtN/sxVqnHPP3vPuRh21T/CW3 FJ5y8HH473HRN/WAsl3ruvxjh1gzHlc37RKJe//mVaH39eNFNdWnr5V/MxHKL90pIm5ed5l7 k1lwdd2/X4d3bynWFCosmsSpZab/ffesvwtceCq7DggosRRnJBpqMRcVJwIAz87Mvj8DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/net/wireless/ath/ath5k/ahb.c | 2 -- drivers/net/wireless/ath/ath9k/ahb.c | 2 -- 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c index 8e8bcc7a..e9bc9e6 100644 --- a/drivers/net/wireless/ath/ath5k/ahb.c +++ b/drivers/net/wireless/ath/ath5k/ahb.c @@ -185,7 +185,6 @@ static int ath_ahb_probe(struct platform_device *pdev) err_free_hw: ieee80211_free_hw(hw); - platform_set_drvdata(pdev, NULL); err_iounmap: iounmap(mem); err_out: @@ -221,7 +220,6 @@ static int ath_ahb_remove(struct platform_device *pdev) ath5k_deinit_ah(ah); iounmap(ah->iobase); - platform_set_drvdata(pdev, NULL); ieee80211_free_hw(hw); return 0; diff --git a/drivers/net/wireless/ath/ath9k/ahb.c b/drivers/net/wireless/ath/ath9k/ahb.c index d1ff3c2..072e4b5 100644 --- a/drivers/net/wireless/ath/ath9k/ahb.c +++ b/drivers/net/wireless/ath/ath9k/ahb.c @@ -150,7 +150,6 @@ static int ath_ahb_probe(struct platform_device *pdev) free_irq(irq, sc); err_free_hw: ieee80211_free_hw(hw); - platform_set_drvdata(pdev, NULL); return ret; } @@ -164,7 +163,6 @@ static int ath_ahb_remove(struct platform_device *pdev) ath9k_deinit_device(sc); free_irq(sc->irq, sc); ieee80211_free_hw(sc->hw); - platform_set_drvdata(pdev, NULL); } return 0;