From patchwork Tue May 7 04:58:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241956 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5BFEE2C00E8 for ; Tue, 7 May 2013 14:58:43 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755717Ab3EGE6j (ORCPT ); Tue, 7 May 2013 00:58:39 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:55456 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754324Ab3EGE6i (ORCPT ); Tue, 7 May 2013 00:58:38 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MME00MM0WHMLYD0@mailout4.samsung.com> for netdev@vger.kernel.org; Tue, 07 May 2013 13:58:37 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.50]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id AE.D4.19350.DF988815; Tue, 07 May 2013 13:58:37 +0900 (KST) X-AuditID: cbfee691-b7fe56d000004b96-5a-518889fd3f0a Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id AF.23.01422.DF988815; Tue, 07 May 2013 13:58:37 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MME00MPUWHOER71@mmp1.samsung.com>; Tue, 07 May 2013 13:58:37 +0900 (KST) From: Jingoo Han To: "'David S. Miller'" Cc: netdev@vger.kernel.org, Jingoo Han , 'Krzysztof Halasa' , 'Xi Wang' Subject: [PATCH 31/36] net: ethernet: xscale: remove unnecessary platform_set_drvdata() Date: Tue, 07 May 2013 13:58:36 +0900 Message-id: <003001ce4adf$88b7c370$9a274a50$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5K300u/RpvxlBXSaG19zShxLQ2Ww== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsVy+t8zI92/nR2BBoffKFrMOd/CYnF54SVW i7P9p5ksji0Qs/g/+xmrA6vHlpU3mTx2zrrL7vH/xT8mj74tqxg9Pm+SC2CN4rJJSc3JLEst 0rdL4Mp4fZat4DxnxeqtR1kaGBdxdDFyckgImEg86FrLDmGLSVy4t56ti5GLQ0hgGaPEj87P rDBFrxrfsUMkFjFKfN0ynxHC+cUocerRKiaQKjYBNYkvXw4DVXFwiAjoSsy/bgJSwyzQyChx 5kQ3I0iNsECkRPvBdcwgNouAqsSj7q9gq3kFLCU+9LSwQNiCEj8m3wOzmQW0JNbvPM4EYctL bF7zlhniIgWJHWdfg80UEdCT6Lh0nQ2iRkRi34t3YMdJCBxil5i38QAjxDIBiW+TD7GAHCch ICux6QDUHEmJgytusExgFJuFZPUsJKtnIVk9C8mKBYwsqxhFUwuSC4qT0otM9YoTc4tL89L1 kvNzNzFCIm/iDsb7B6wPMSYDrZ/ILCWanA+M3LySeENjMyMLUxNTYyNzSzPShJXEedVbrAOF BNITS1KzU1MLUovii0pzUosPMTJxcEo1MPJVtUpt/nT1hPeBk7Nbw57+faky8dHS/yF1z2c6 TeBqXC+47aLzH5YrK4LKJtRMvjx54kMGptn7a3+evDfV83LN2rraXVN+TIn9mMy76UmbN6O/ g/7dmug3bYZbui4+8TZ7urV6l+DB1cw+G6a9YFXbX8XGd3y3Qaj/ezOf+5/kPsm2Hja1EVyr xFKckWioxVxUnAgAj8KZlNICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsVy+t9jAd2/nR2BBme75SzmnG9hsbi88BKr xdn+00wWxxaIWfyf/YzVgdVjy8qbTB47Z91l9/j/4h+TR9+WVYwenzfJBbBGNTDaZKQmpqQW KaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gAtV1IoS8wpBQoFJBYX K+nbYZoQGuKmawHTGKHrGxIE12NkgAYS1jFmvD7LVnCes2L11qMsDYyLOLoYOTkkBEwkXjW+ Y4ewxSQu3FvP1sXIxSEksIhR4uuW+YwQzi9GiVOPVjGBVLEJqEl8+XIYqIODQ0RAV2L+dROQ GmaBRkaJMye6GUFqhAUiJdoPrmMGsVkEVCUedX8F28ArYCnxoaeFBcIWlPgx+R6YzSygJbF+ 53EmCFteYvOat8wQFylI7Dj7GmymiICeRMel62wQNSIS+168Y5zAKDALyahZSEbNQjJqFpKW BYwsqxhFUwuSC4qT0nON9IoTc4tL89L1kvNzNzGC4/qZ9A7GVQ0WhxgFOBiVeHgVTrUHCrEm lhVX5h5ilOBgVhLhldbuCBTiTUmsrEotyo8vKs1JLT7EmAz06URmKdHkfGDKySuJNzQ2MTOy NDKzMDIxNydNWEmc92CrdaCQQHpiSWp2ampBahHMFiYOTqkGxrjzSQzewvrJBVwMhvPMLwr9 0Lrsf7jZfdpVYYXyK7Wmv4tX/5HPL+m9PD3xV4j+o7u9xS1h8+zMdf7M54+fdal03nGLDU38 MuWL1LYwO3L4nNMterlDoWTHtC/r9URPrcuNim5TqAxdXRJeIpj1PiG9YctC4QKxz1kxnzQS r+zqqHsm0N2oxFKckWioxVxUnAgAPZfeVC8DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/net/ethernet/xscale/ixp4xx_eth.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c index 6958a5e..3d689fc 100644 --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c @@ -1472,7 +1472,6 @@ err_phy_dis: phy_disconnect(port->phydev); err_free_mem: npe_port_tab[NPE_ID(port->id)] = NULL; - platform_set_drvdata(pdev, NULL); release_resource(port->mem_res); err_npe_rel: npe_release(port->npe); @@ -1489,7 +1488,6 @@ static int eth_remove_one(struct platform_device *pdev) unregister_netdev(dev); phy_disconnect(port->phydev); npe_port_tab[NPE_ID(port->id)] = NULL; - platform_set_drvdata(pdev, NULL); npe_release(port->npe); release_resource(port->mem_res); free_netdev(dev);