From patchwork Tue May 7 04:48:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241951 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6A45E2C010F for ; Tue, 7 May 2013 14:48:46 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758189Ab3EGEsn (ORCPT ); Tue, 7 May 2013 00:48:43 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:53583 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757580Ab3EGEsm (ORCPT ); Tue, 7 May 2013 00:48:42 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MME00200W0ID8C0@mailout4.samsung.com> for netdev@vger.kernel.org; Tue, 07 May 2013 13:48:41 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.50]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 7D.E3.13955.8A788815; Tue, 07 May 2013 13:48:40 +0900 (KST) X-AuditID: cbfee68f-b7f066d000003683-e0-518887a892ba Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 08.E0.01422.8A788815; Tue, 07 May 2013 13:48:40 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MME0043TW14SIG0@mmp1.samsung.com>; Tue, 07 May 2013 13:48:40 +0900 (KST) From: Jingoo Han To: "'David S. Miller'" Cc: netdev@vger.kernel.org, Jingoo Han , 'Joshua Kinard' Subject: [PATCH 25/36] net: ethernet: sgi: remove unnecessary platform_set_drvdata() Date: Tue, 07 May 2013 13:48:40 +0900 Message-id: <002a01ce4ade$24dbc1e0$6e9345a0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5K3guGmHSkVG9ETAacCaFxYDpyEQ== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCIsWRmVeSWpSXmKPExsVy+t8zI90V7R2BBi+myljMOd/CYnF54SVW i523ZCyOLRBzYPHYsvImk8fl72+YPfq2rGL0+LxJLoAlissmJTUnsyy1SN8ugStj0/s2poL9 bBW//i1lbWDcztrFyMkhIWAisXHROkYIW0ziwr31bF2MXBxCAssYJb4928UOU/TxyBYWiMQi RokJD1YzQTi/GCVmzJnPAlLFJqAm8eXLYaAODg4RAV2J+ddNQMLMAkkSbTfbwDYIC4RJbH3Z zQRiswioSuycuIENxOYVsJQ4f3gWM4QtKPFj8j0WiF4tifU7jzNB2PISm9e8ZYY4SEFix9nX YDNFBPQkpi5YzwhRIyKx78U7RpDbJAQ2sUucbVvHDLFMQOLb5EMsILdJCMhKbDoANUdS4uCK GywTGMVmIVk9C8nqWUhWz0KyYgEjyypG0dSC5ILipPQiY73ixNzi0rx0veT83E2MkBjr38F4 94D1IcZkoPUTmaVEk/OBMZpXEm9obGZkYWpiamxkbmlGmrCSOK9ai3WgkEB6YklqdmpqQWpR fFFpTmrxIUYmDk6pBsaKiVEzeCoCbvJItm9zL2CIWXtxnfXW6i8sF+++e7J+jqPu7eN6p0SN Y+ZvybAwPaz7bJk3/9V0jp1sh97uFtsXcnRf3UYF5+R8lcRts9peXJoZtjD41+conlNlWVw9 amevc5+dXhp4zvvGg96Y3f8tGVrKitadEHv/79BfvzADdyFRySfqz84psRRnJBpqMRcVJwIA YIOIvccCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIKsWRmVeSWpSXmKPExsVy+t9jAd0V7R2BBicPSVjMOd/CYnF54SVW i523ZCyOLRBzYPHYsvImk8fl72+YPfq2rGL0+LxJLoAlqoHRJiM1MSW1SCE1Lzk/JTMv3VbJ OzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwdoo5JCWWJOKVAoILG4WEnfDtOE0BA3XQuY xghd35AguB4jAzSQsI4xY9P7NqaC/WwVv/4tZW1g3M7axcjJISFgIvHxyBYWCFtM4sK99Wxd jFwcQgKLGCUmPFjNBOH8YpSYMWc+WBWbgJrEly+H2bsYOThEBHQl5l83AQkzCyRJtN1sYwSx hQXCJLa+7GYCsVkEVCV2TtzABmLzClhKnD88ixnCFpT4MfkeC0SvlsT6nceZIGx5ic1r3jJD HKQgsePsa7CZIgJ6ElMXrGeEqBGR2PfiHeMERoFZSEbNQjJqFpJRs5C0LGBkWcUomlqQXFCc lJ5rpFecmFtcmpeul5yfu4kRHMHPpHcwrmqwOMQowMGoxMOrcKo9UIg1say4MvcQowQHs5II r7R2R6AQb0piZVVqUX58UWlOavEhxmSgTycyS4km5wOTS15JvKGxiZmRpZGZhZGJuTlpwkri vAdbrQOFBNITS1KzU1MLUotgtjBxcEo1MPZek2mYejDimMQelTX3w6YnNTbN2zlN7ve5L08N 2QRkOVPKfUtkaxWsmd+oszKtTC49J3lmFmtl/e6zl6cFFjVVfT+/nSm4Y8ettIsfpBkW+eX5 8vtysdZYVt79fqlMjGVp3qlvC2fVqL4J3tFgVHVo+pLJL8rnRbGl5iSkKl3q+2Q2q73OXoml OCPRUIu5qDgRACtE3+skAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/net/ethernet/sgi/meth.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/sgi/meth.c b/drivers/net/ethernet/sgi/meth.c index 4bdbaad9..9f5f35e 100644 --- a/drivers/net/ethernet/sgi/meth.c +++ b/drivers/net/ethernet/sgi/meth.c @@ -863,7 +863,6 @@ static int __exit meth_remove(struct platform_device *pdev) unregister_netdev(dev); free_netdev(dev); - platform_set_drvdata(pdev, NULL); return 0; }