From patchwork Tue May 7 04:46:55 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241949 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B578D2C00FD for ; Tue, 7 May 2013 14:47:01 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757899Ab3EGEq6 (ORCPT ); Tue, 7 May 2013 00:46:58 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:53236 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756366Ab3EGEq4 (ORCPT ); Tue, 7 May 2013 00:46:56 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MME001J3VY3THB0@mailout4.samsung.com> for netdev@vger.kernel.org; Tue, 07 May 2013 13:46:55 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 33.67.19730.F3788815; Tue, 07 May 2013 13:46:55 +0900 (KST) X-AuditID: cbfee68e-b7efa6d000004d12-62-5188873f7dd9 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 8F.42.08957.F3788815; Tue, 07 May 2013 13:46:55 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MME0043DVY724J0@mmp1.samsung.com>; Tue, 07 May 2013 13:46:55 +0900 (KST) From: Jingoo Han To: "'David S. Miller'" Cc: netdev@vger.kernel.org, Jingoo Han , Wei Yongjun Subject: [PATCH 23/36] net: ethernet: s6gmac: remove unnecessary platform_set_drvdata() Date: Tue, 07 May 2013 13:46:55 +0900 Message-id: <002801ce4add$e65e2340$b31a69c0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5K3dIjC5Q+pEI+SeOk2xob61G/IQ== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsVy+t8zA1379o5Ag6apahZzzrewWFxeeInV 4tgCMYud6zrZHVg8tqy8yeTRt2UVo8fSe0cZPT5vkgtgieKySUnNySxLLdK3S+DK2Ph0JmvB BbaKaQ/OMTUwHmLtYuTkkBAwkTi25jkjhC0mceHeerYuRi4OIYFljBIXD79lhinasHcuVGIR o8S8h3fZIZxfjBJH351jB6liE1CT+PLlMJDNwSEioCsx/7oJSJhZIFui9d9ZNhBbWCBSYk5D J9hmFgFVic8bN4Et4BWwlOiYe5wdwhaU+DH5HgtEr5bE+p3HmSBseYnNa2AOUpDYcfY12NUi AnoSXyc/gqoRkdj34h0jyG0SAuvYJba+nMMIsUxA4tvkQywgt0kIyEpsOgA1R1Li4IobLBMY xWYhWT0LyepZSFbPQrJiASPLKkbR1ILkguKk9CIjveLE3OLSvHS95PzcTYyQKOvbwXjzgPUh xmSg9ROZpUST84FRmlcSb2hsZmRhamJqbGRuaUaasJI4r1qLdaCQQHpiSWp2ampBalF8UWlO avEhRiYOTqkGxoAjDZcd9Vpe793kMT9zfsOmqgTfUpvvkz/37Srcl3a3bh631nSp4Fb3sLST E+M+XDkmVnBuhvUNtZnfN+qfF2BwDwnSquJd5PAg+IqRs7FYx6pG2/YSmyU8a7cKOadyuGUk l3t7Wt7bzllcEGf2rme7suoVQ/lNfwueX9r9xiaQxUqoWIhLiaU4I9FQi7moOBEAXxW/C8gC AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEKsWRmVeSWpSXmKPExsVy+t9jAV379o5AgztXFC3mnG9hsbi88BKr xbEFYhY713WyO7B4bFl5k8mjb8sqRo+l944yenzeJBfAEtXAaJORmpiSWqSQmpecn5KZl26r 5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtFJJoSwxpxQoFJBYXKykb4dpQmiIm64F TGOErm9IEFyPkQEaSFjHmLHx6UzWggtsFdMenGNqYDzE2sXIySEhYCKxYe9cNghbTOLCvfVA NheHkMAiRol5D++yQzi/GCWOvjvHDlLFJqAm8eXLYSCbg0NEQFdi/nUTkDCzQLZE67+zYIOE BSIl5jR0gi1gEVCV+LxxEzOIzStgKdEx9zg7hC0o8WPyPRaIXi2J9TuPM0HY8hKb17xlhjhI QWLH2deMILaIgJ7E18mPoGpEJPa9eMc4gVFgFpJRs5CMmoVk1CwkLQsYWVYxiqYWJBcUJ6Xn GuoVJ+YWl+al6yXn525iBMfwM6kdjCsbLA4xCnAwKvHwKpxqDxRiTSwrrsw9xCjBwawkwiut 3REoxJuSWFmVWpQfX1Sak1p8iDEZ6NOJzFKiyfnA9JJXEm9obGJmZGlkZmFkYm5OmrCSOO+B VutAIYH0xJLU7NTUgtQimC1MHJxSDYwzHPVcZtQXXHpnk2n2W06Qg+lRSrtv2tqcKSsc5j0w PrHgp5/n2TDTeTNefeQ13NIenXBamOtPSkWTZqx48C1G+3l6Befuskw5s+yfxE4lIQ4/0ft8 P9N3//v8RGPNlYbqrFo7qeyYY7qvX4jHcQrMd2ln1LVQPyp2s6K6sy1sppp7wq+iB0osxRmJ hlrMRcWJAGPGRGclAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/net/ethernet/s6gmac.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/s6gmac.c b/drivers/net/ethernet/s6gmac.c index b6739af..a99739c 100644 --- a/drivers/net/ethernet/s6gmac.c +++ b/drivers/net/ethernet/s6gmac.c @@ -1040,7 +1040,6 @@ static int s6gmac_remove(struct platform_device *pdev) unregister_netdev(dev); free_irq(dev->irq, dev); free_netdev(dev); - platform_set_drvdata(pdev, NULL); } return 0; }