From patchwork Tue May 7 04:44:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241947 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7B1682C00FD for ; Tue, 7 May 2013 14:44:28 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760673Ab3EGEoW (ORCPT ); Tue, 7 May 2013 00:44:22 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:62441 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759401Ab3EGEoT (ORCPT ); Tue, 7 May 2013 00:44:19 -0400 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MME00FPFVTUF080@mailout2.samsung.com> for netdev@vger.kernel.org; Tue, 07 May 2013 13:44:18 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 29.26.04074.2A688815; Tue, 07 May 2013 13:44:18 +0900 (KST) X-AuditID: cbfee690-b7f136d000000fea-49-518886a22361 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id F3.DF.01422.2A688815; Tue, 07 May 2013 13:44:18 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MME00C52VTTCD00@mmp2.samsung.com>; Tue, 07 May 2013 13:44:17 +0900 (KST) From: Jingoo Han To: "'David S. Miller'" Cc: netdev@vger.kernel.org, Jingoo Han , 'Wei Yongjun' , Eric Dumazet , 'Roland Stigge' Subject: [PATCH 21/36] net: ethernet: nxp: remove unnecessary platform_set_drvdata() Date: Tue, 07 May 2013 13:44:17 +0900 Message-id: <002601ce4add$888a35b0$999ea110$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5K3U6BlOhqJUalR5+R9p5I+eR1aA== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBIsWRmVeSWpSXmKPExsVy+t8zA91FbR2BBisvcVvMOd/CYvH02CN2 i8sLL7FaHFsgZjF5yVlWi53rOtkd2DzmTN3N6LFl5U0mjwWbSj36tqxi9Fh67yijx+dNcgFs UVw2Kak5mWWpRfp2CVwZl649Yys4w1kx5Z93A+Nkji5GTg4JAROJl39nsUDYYhIX7q1n62Lk 4hASWMYo8W3ZN0aYohe3VjJBJKYzSmy70c8K4fxilDj2bAtYFZuAmsSXL4fZuxg5OEQEdCXm XzcBqWEW2M4oMX3lCiaQGmGBMImrFx+D1bMIqErsmjuXGcTmFbCUuLt1GjuELSjxY/I9sJOY BbQk1u88zgRhy0tsXvOWGeIiBYkdZ1+DzRER0JM4vH4RVL2IxL4X7xhBFksIXGKXuPxlIhvE MgGJb5MPsYAcJyEgK7HpANQcSYmDK26wTGAUm4Vk9Swkq2chWT0LyYoFjCyrGEVTC5ILipPS i0z0ihNzi0vz0vWS83M3MUJiccIOxnsHrA8xJgOtn8gsJZqcD4zlvJJ4Q2MzIwtTE1NjI3NL M9KElcR51VusA4UE0hNLUrNTUwtSi+KLSnNSiw8xMnFwSjUwckt65PyRmN1938rRT7Hu3mee zpkX7nqEKphKs/pVzNydeklmflI4Qyxb5Gor8dfb62y+ZF7esPTfvhe8Gqq1DGdWPJe5FRJv JSOw8Qa/lpr+2n3mLg+LgnlaTyQnL32W8HtOxTOG+6+LN/Io9K6dGFHD/GDKB/dVjz0lF56Z INHn0dJ1nGmSEktxRqKhFnNRcSIAp4D9W9sCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKKsWRmVeSWpSXmKPExsVy+t9jQd1FbR2BBv/Ps1vMOd/CYvH02CN2 i8sLL7FaHFsgZjF5yVlWi53rOtkd2DzmTN3N6LFl5U0mjwWbSj36tqxi9Fh67yijx+dNcgFs UQ2MNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAVygp lCXmlAKFAhKLi5X07TBNCA1x07WAaYzQ9Q0JgusxMkADCesYMy5de8ZWcIazYso/7wbGyRxd jJwcEgImEi9urWSCsMUkLtxbz9bFyMUhJDCdUWLbjX5WCOcXo8SxZ1sYQarYBNQkvnw5zN7F yMEhIqArMf+6CUgNs8B2RonpK1eATRIWCJO4evExWD2LgKrErrlzmUFsXgFLibtbp7FD2IIS PybfYwGxmQW0JNbvPM4EYctLbF7zlhniIgWJHWdfg80REdCTOLx+EVS9iMS+F+8YJzAKzEIy ahaSUbOQjJqFpGUBI8sqRtHUguSC4qT0XCO94sTc4tK8dL3k/NxNjOBIfya9g3FVg8UhRgEO RiUeXoVT7YFCrIllxZW5hxglOJiVRHiltTsChXhTEiurUovy44tKc1KLDzEmA306kVlKNDkf mITySuINjU3MjCyNzCyMTMzNSRNWEuc92GodKCSQnliSmp2aWpBaBLOFiYNTqoGRRaEqrNWR +xJ/sTND4nyNuNDfJhrz0x5teqnOGWEU+jKS4+ScotVifv3uzOJhD5dHaOoms+yaJ+S9qtRC 4+vLZQe0nU4oNrFNPthu8EPhgNPOaP2fqyqz40x3yS5gfDVdYUdbo+FzZ6kPc8Uf/Es5e6l7 Zmimn7/t1FvnZ25dbpb6s6igs0SJpTgj0VCLuag4EQBAnfH8OAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han Tested-by: Roland Stigge Acked-by: Roland Stigge --- drivers/net/ethernet/nxp/lpc_eth.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index 55a5548..a061b93 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c @@ -1483,7 +1483,6 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) return 0; err_out_unregister_netdev: - platform_set_drvdata(pdev, NULL); unregister_netdev(ndev); err_out_dma_unmap: if (!use_iram_for_net(&pldat->pdev->dev) || @@ -1511,7 +1510,6 @@ static int lpc_eth_drv_remove(struct platform_device *pdev) struct netdata_local *pldat = netdev_priv(ndev); unregister_netdev(ndev); - platform_set_drvdata(pdev, NULL); if (!use_iram_for_net(&pldat->pdev->dev) || pldat->dma_buff_size > lpc32xx_return_iram_size())