From patchwork Tue May 7 04:37:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241942 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8B7052C012A for ; Tue, 7 May 2013 14:37:48 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759366Ab3EGEhm (ORCPT ); Tue, 7 May 2013 00:37:42 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:61461 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757281Ab3EGEhi (ORCPT ); Tue, 7 May 2013 00:37:38 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MME00JK0VIPZ850@mailout2.samsung.com> for netdev@vger.kernel.org; Tue, 07 May 2013 13:37:37 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 61.FD.13955.11588815; Tue, 07 May 2013 13:37:37 +0900 (KST) X-AuditID: cbfee68f-b7f066d000003683-fd-51888511f461 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 7A.CF.08957.11588815; Tue, 07 May 2013 13:37:37 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MME00BVKVIOYF00@mmp2.samsung.com>; Tue, 07 May 2013 13:37:37 +0900 (KST) From: Jingoo Han To: "'David S. Miller'" Cc: netdev@vger.kernel.org, Jingoo Han , 'Lennert Buytenhek' , 'Thomas Petazzoni' Subject: [PATCH 17/36] net: ethernet: marvell: remove unnecessary platform_set_drvdata() Date: Tue, 07 May 2013 13:37:36 +0900 Message-id: <002101ce4adc$9992ac30$ccb80490$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5K3FMrk+rvMhUcTey0jenxyiYttw== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsVy+t8zY13B1o5Agwm7+Sy2N69jsZhzvoXF 4vLCS6wWxxaIWTx90MTkwOqxZeVNJo8nmy4yevRtWcXo8XmTnMeqPy2sAaxRXDYpqTmZZalF +nYJXBlzd9xgK9jJV/Hh9VqWBsYNPF2MnBwSAiYSD16sYoKwxSQu3FvP1sXIxSEksIxRYs+F i4wwRatb9zFCJKYzSsxbe5AVJCEk8ItRYstCaxCbTUBN4suXw+xdjBwcIgK6EvOvm4DUMwus YJRoOncdrF5YIEpiw/VeNpAaFgFVib2TSkFMXgFLiUMneEEqeAUEJX5MvscCYjMLaEms33mc CcKWl9i85i0zxDkKEjvOvmaE2KQn8fJnBESJiMS+F+/ArpQQOMYu8X7LXbB6FgEBiW+TD7GA 1EsIyEpsOgA1RlLi4IobLBMYxWYh2TwLyeZZSDbPQrJiASPLKkbR1ILkguKk9CJjveLE3OLS vHS95PzcTYyQmOvfwXj3gPUhxmSg9ROZpUST84Exm1cSb2hsZmRhamJqbGRuaUaasJI4r1qL daCQQHpiSWp2ampBalF8UWlOavEhRiYOTqkGRobbboxvkmv39Rcy+fAfiHd7nyEX53XPibV5 9dRqvSqll2U704w13v9SvpkRebD7QLe/s3x1qsWLtV8X5CSVLvT9PNHzX8Tyum3NL+7qfOOd IPaCRdtMwied86Iuz5/JDedldrjtfPDlaUVni5dOd4xMd279s3OTZ26ZXLj69/3l9Y6H5192 VWIpzkg01GIuKk4EAGBsa6TPAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJKsWRmVeSWpSXmKPExsVy+t9jQV3B1o5Ag0nXuSy2N69jsZhzvoXF 4vLCS6wWxxaIWTx90MTkwOqxZeVNJo8nmy4yevRtWcXo8XmTnMeqPy2sAaxRDYw2GamJKalF Cql5yfkpmXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUDLlRTKEnNKgUIBicXF Svp2mCaEhrjpWsA0Ruj6hgTB9RgZoIGEdYwZc3fcYCvYyVfx4fValgbGDTxdjJwcEgImEqtb 9zFC2GISF+6tZ+ti5OIQEpjOKDFv7UFWkISQwC9GiS0LrUFsNgE1iS9fDrN3MXJwiAjoSsy/ bgJSzyywglGi6dx1sHphgSiJDdd72UBqWARUJfZOKgUxeQUsJQ6d4AWp4BUQlPgx+R4LiM0s oCWxfudxJghbXmLzmrfMEOcoSOw4+5oRYpOexMufERAlIhL7XrxjnMAoMAvJpFlIJs1CMmkW kpYFjCyrGEVTC5ILipPScw31ihNzi0vz0vWS83M3MYIj+pnUDsaVDRaHGAU4GJV4eBVOtQcK sSaWFVfmHmKU4GBWEuGV1u4IFOJNSaysSi3Kjy8qzUktPsSYDPTmRGYp0eR8YLLJK4k3NDYx M7I0MrMwMjE3J01YSZz3QKt1oJBAemJJanZqakFqEcwWJg5OqQbGmu4Zk/qVy/raKmYqPNSf kmI+hdtnUmjb/3zW9eEu96da58XXXLMTiRTYITj3vngs30STZzfcbh0SLbg0aeMBs/ttTplr 3zhVuaasXHP9xJYls25xW///cS7wh87VkBu3faY+XBIfcaZb3FEj3XqiqqDSlQO7DvrcYfkY MrNMqeVuwxeG42yGSizFGYmGWsxFxYkApNKMEiwDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/net/ethernet/marvell/mv643xx_eth.c | 2 -- drivers/net/ethernet/marvell/mvneta.c | 2 -- drivers/net/ethernet/marvell/pxa168_eth.c | 1 - 3 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index d0afeea..eaa8c33 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c @@ -2813,8 +2813,6 @@ static int mv643xx_eth_remove(struct platform_device *pdev) free_netdev(mp->dev); - platform_set_drvdata(pdev, NULL); - return 0; } diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index c966785..cd0ea20 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -2804,8 +2804,6 @@ static int mvneta_remove(struct platform_device *pdev) irq_dispose_mapping(dev->irq); free_netdev(dev); - platform_set_drvdata(pdev, NULL); - return 0; } diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c index 339bb32..2602cf7 100644 --- a/drivers/net/ethernet/marvell/pxa168_eth.c +++ b/drivers/net/ethernet/marvell/pxa168_eth.c @@ -1602,7 +1602,6 @@ static int pxa168_eth_remove(struct platform_device *pdev) unregister_netdev(dev); cancel_work_sync(&pep->tx_timeout_task); free_netdev(dev); - platform_set_drvdata(pdev, NULL); return 0; }