From patchwork Tue May 7 04:29:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241937 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4A8192C0089 for ; Tue, 7 May 2013 14:29:12 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933216Ab3EGE3H (ORCPT ); Tue, 7 May 2013 00:29:07 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:49943 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932664Ab3EGE3E (ORCPT ); Tue, 7 May 2013 00:29:04 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MME001LYV4ATHA0@mailout4.samsung.com> for netdev@vger.kernel.org; Tue, 07 May 2013 13:29:03 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id A8.F5.19350.D0388815; Tue, 07 May 2013 13:29:01 +0900 (KST) X-AuditID: cbfee691-b7fe56d000004b96-89-5188830df054 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id AD.5D.08957.D0388815; Tue, 07 May 2013 13:29:01 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MME001OYV4DSDO0@mmp1.samsung.com>; Tue, 07 May 2013 13:29:01 +0900 (KST) From: Jingoo Han To: "'David S. Miller'" Cc: netdev@vger.kernel.org, Jingoo Han , 'Joseph CHANG' , 'Matthew Leach' Subject: [PATCH 12/36] net: ethernet: davicom: remove unnecessary platform_set_drvdata() Date: Tue, 07 May 2013 13:29:01 +0900 Message-id: <001c01ce4adb$66469cc0$32d3d640$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5K2yUjXJ835CkHSz2rQV5wpqOJzQ== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLIsWRmVeSWpSXmKPExsVy+t8zY13e5o5Ag7XzNCzmnG9hsbi88BKr xfoD35gsGpcuY7E4tkDMgdVjy8qbTB47Z91l95j6YR2LR9+WVYwenzfJBbBGcdmkpOZklqUW 6dslcGVc69jKUnCBvaJrzw62BsZ9bF2MnBwSAiYSHXfaWCBsMYkL99YDxbk4hASWMUqs/juD EaZoRuNqVhBbSGARo8TpgyEQ9i9GiXf/dUBsNgE1iS9fDrN3MXJwiAjoSsy/bgIyh1mgn1Fi /t9/zCA1wgJREmdm3gabySKgKrF2939mkHpeAUuJX6v1QMK8AoISPybfA7uHWUBLYv3O40wQ trzE5jVvmSHOUZDYcfY12BgRAT2JtztWsEHUiEjse/GOEWSvhMAxdonjLx4zQewSkPg2+RAL yC4JAVmJTQeg5khKHFxxg2UCo9gsJKtnIVk9C8nqWUhWLGBkWcUomlqQXFCclF5kqlecmFtc mpeul5yfu4kREnUTdzDeP2B9iDEZaP1EZinR5Hxg1OaVxBsamxlZmJqYGhuZW5qRJqwkzqve Yh0oJJCeWJKanZpakFoUX1Sak1p8iJGJg1OqgfHwvhZre/PWqMMG3DtWzrJ/eE84+MOSnzdC 33EkilTys4iseHjV9cEV1uIJZ25N+6d7xXFTyn72a36fzNx8T7qumWou2iu1pfcww9KLvx4K vmR+u7jS4np19kKmRxnRnW6pqn9XW69f6+LYNYe7eH9N/QnrZWbTD1eecIjXf8fmbhsjMeHo 7hYlluKMREMt5qLiRACbPey40AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFKsWRmVeSWpSXmKPExsVy+t9jAV3e5o5Ag/1XVCzmnG9hsbi88BKr xfoD35gsGpcuY7E4tkDMgdVjy8qbTB47Z91l95j6YR2LR9+WVYwenzfJBbBGNTDaZKQmpqQW KaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gAtV1IoS8wpBQoFJBYX K+nbYZoQGuKmawHTGKHrGxIE12NkgAYS1jFmXOvYylJwgb2ia88OtgbGfWxdjJwcEgImEjMa V7NC2GISF+6tB4sLCSxilDh9MATC/sUo8e6/DojNJqAm8eXLYfYuRg4OEQFdifnXTboYuTiY BfoZJeb//ccMUiMsECVxZuZtRhCbRUBVYu3u/8wg9bwClhK/VuuBhHkFBCV+TL7HAmIzC2hJ rN95nAnClpfYvOYtM8Q5ChI7zr4GGyMioCfxdscKNogaEYl9L94xTmAUmIVk1Cwko2YhGTUL ScsCRpZVjKKpBckFxUnpuYZ6xYm5xaV56XrJ+bmbGMEx/UxqB+PKBotDjAIcjEo8vAqn2gOF WBPLiitzDzFKcDArifBKa3cECvGmJFZWpRblxxeV5qQWH2JMBnp0IrOUaHI+MN3klcQbGpuY GVkamVkYmZibkyasJM57oNU6UEggPbEkNTs1tSC1CGYLEwenVANjq0jnyslL6xX3uCWqK738 4fif/23pdGt19Y+WO0y89/U+4fJx9DGVmD+/ovGE55qp//t3xHwK2GBz/5C3/TxxyUlBhlzy d3YZXup74C/ffuNS4cN4+QKmzhUXnHs5npRc5WU3VeFOiqi76qAjceNxxT3pYxOLteeoTN9c VRowwS/S/pf8MRYlluKMREMt5qLiRACzJ7DULQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/net/ethernet/davicom/dm9000.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c index 9105465..1ec8b18 100644 --- a/drivers/net/ethernet/davicom/dm9000.c +++ b/drivers/net/ethernet/davicom/dm9000.c @@ -1673,8 +1673,6 @@ dm9000_drv_remove(struct platform_device *pdev) { struct net_device *ndev = platform_get_drvdata(pdev); - platform_set_drvdata(pdev, NULL); - unregister_netdev(ndev); dm9000_release_board(pdev, netdev_priv(ndev)); free_netdev(ndev); /* free device structure */