From patchwork Tue May 7 04:25:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241934 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 0A5962C00F0 for ; Tue, 7 May 2013 14:25:30 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759320Ab3EGEZ0 (ORCPT ); Tue, 7 May 2013 00:25:26 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:59311 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757024Ab3EGEZZ (ORCPT ); Tue, 7 May 2013 00:25:25 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MME00E9UUXZZI80@mailout2.samsung.com> for netdev@vger.kernel.org; Tue, 07 May 2013 13:25:24 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.47]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 6B.5A.31024.43288815; Tue, 07 May 2013 13:25:24 +0900 (KST) X-AuditID: cbfee68d-b7f016d000007930-60-51888234cf57 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 65.3A.01422.33288815; Tue, 07 May 2013 13:25:24 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MME0040TUYBSIB0@mmp1.samsung.com>; Tue, 07 May 2013 13:25:23 +0900 (KST) From: Jingoo Han To: "'David S. Miller'" Cc: netdev@vger.kernel.org, Jingoo Han , Dan Carpenter , 'Rob Herring' Subject: [PATCH 10/36] net: ethernet: calxeda: remove unnecessary platform_set_drvdata() Date: Tue, 07 May 2013 13:25:23 +0900 Message-id: <001a01ce4ada$e498ace0$adca06a0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5K2rfa3C31kk0WS4GU7ne7JJK8lA== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsVy+t8zfV2Tpo5Ag2nnWC1e/5vOYjHnfAuL xeWFl1gtji0Qszi84gCTA6vHgs9X2D22rLzJ5PHx6S0Wj74tqxg9Pm+SC2CN4rJJSc3JLEst 0rdL4MqYfeUpW8FhjoqbawIaGGeydzFyckgImEisXLOKDcIWk7hwbz2QzcUhJLCMUeL2zX9s MEXNj9YyQSQWMUps3dHJCOH8YpTYv+kpM0gVm4CaxJcvh4HGcnCICOhKzL9uAlLDLDCZUWJz 4xmwuLBAlMTehfYg5SwCqhJPLj5jArF5BSwlJl6cwwJhC0r8mHwPzGYW0JJYv/M4E4QtL7F5 zVtmiIMUJHacfc0IYosI6EncXL6PDaJGRGLfi3dgt0kIHGKXuHX/JxvEMgGJb5MPsYDcICEg K7HpANQcSYmDK26wTGAUm4Vk9Swkq2chWT0LyYoFjCyrGEVTC5ILipPSiwz1ihNzi0vz0vWS 83M3MULirncH4+0D1ocYk4HWT2SWEk3OB8ZtXkm8obGZkYWpiamxkbmlGWnCSuK8ai3WgUIC 6YklqdmpqQWpRfFFpTmpxYcYmTg4pRoYV3HkHJp1rejXTSH3FY6fPY+bck2dsIuf69Wrn6qP c2xWsMmptS+pl65/2RqXu4E5/tjslGvr1wZ9e7nAZNq60oyjl632bfsauKHV6HCp4gKhX6zm iTMUvKzY5KbPnnXlbLL2rx2Rn0KEYtiXnfFULJllvDLu0ITJqokT7W3eHa25en/tp92vWJVY ijMSDbWYi4oTATQj4fPRAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNKsWRmVeSWpSXmKPExsVy+t9jAV2Tpo5Agz9fGC1e/5vOYjHnfAuL xeWFl1gtji0Qszi84gCTA6vHgs9X2D22rLzJ5PHx6S0Wj74tqxg9Pm+SC2CNamC0yUhNTEkt UkjNS85PycxLt1XyDo53jjc1MzDUNbS0MFdSyEvMTbVVcvEJ0HXLzAFarqRQlphTChQKSCwu VtK3wzQhNMRN1wKmMULXNyQIrsfIAA0krGPMmH3lKVvBYY6Km2sCGhhnsncxcnJICJhIND9a ywRhi0lcuLeerYuRi0NIYBGjxNYdnYwQzi9Gif2bnjKDVLEJqEl8+XIYqJuDQ0RAV2L+dROQ GmaByYwSmxvPgMWFBaIk9i60BylnEVCVeHLxGdgCXgFLiYkX57BA2IISPybfA7OZBbQk1u88 zgRhy0tsXvOWGeIgBYkdZ18zgtgiAnoSN5fvY4OoEZHY9+Id4wRGgVlIRs1CMmoWklGzkLQs YGRZxSiaWpBcUJyUnmukV5yYW1yal66XnJ+7iREc1c+kdzCuarA4xCjAwajEw6twqj1QiDWx rLgy9xCjBAezkgivtHZHoBBvSmJlVWpRfnxRaU5q8SHGZKBPJzJLiSbnAxNOXkm8obGJmZGl kZmFkYm5OWnCSuK8B1utA4UE0hNLUrNTUwtSi2C2MHFwSjUwuiRaNjHu38a3YpPfrNJ/E1Y/ fX34kJTcxsZX+gfTFpv4Pdyc4Z5y4peJkIyy/hEW7cWWOiGdJgGbqx6HldWkHD6y4oXQ9QPP 3BfN0Xm028Dg+Lwqb5Op/uqP9p+8mZ4XXBVR3Pfz7spPGax27hKS6x7O23bpvcUB5qY7rgve /Noc/WzmhXijFCWW4oxEQy3mouJEAMY95mYuAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han Acked-by: Rob Herring --- drivers/net/ethernet/calxeda/xgmac.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c index 4a1f2fa..7cb148c 100644 --- a/drivers/net/ethernet/calxeda/xgmac.c +++ b/drivers/net/ethernet/calxeda/xgmac.c @@ -1790,7 +1790,6 @@ err_io: free_netdev(ndev); err_alloc: release_mem_region(res->start, resource_size(res)); - platform_set_drvdata(pdev, NULL); return ret; } @@ -1813,7 +1812,6 @@ static int xgmac_remove(struct platform_device *pdev) free_irq(ndev->irq, ndev); free_irq(priv->pmt_irq, ndev); - platform_set_drvdata(pdev, NULL); unregister_netdev(ndev); netif_napi_del(&priv->napi);