From patchwork Tue May 7 04:20:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241930 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id CF2082C014B for ; Tue, 7 May 2013 14:20:15 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758359Ab3EGEUK (ORCPT ); Tue, 7 May 2013 00:20:10 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:48459 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753108Ab3EGEUJ (ORCPT ); Tue, 7 May 2013 00:20:09 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MME00MHEUPJLYB0@mailout4.samsung.com> for netdev@vger.kernel.org; Tue, 07 May 2013 13:20:07 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.47]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 2B.A0.19350.7F088815; Tue, 07 May 2013 13:20:07 +0900 (KST) X-AuditID: cbfee691-b7fe56d000004b96-1c-518880f79e96 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 84.E8.01422.7F088815; Tue, 07 May 2013 13:20:07 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MME00109UPJSDN0@mmp1.samsung.com>; Tue, 07 May 2013 13:20:07 +0900 (KST) From: Jingoo Han To: "'David S. Miller'" Cc: netdev@vger.kernel.org, Jingoo Han , 'Richard Cochran' Subject: [PATCH 06/36] net: ethernet: adi: remove unnecessary platform_set_drvdata() Date: Tue, 07 May 2013 13:20:07 +0900 Message-id: <001601ce4ada$27ce23b0$776a6b10$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5K2gI5h35FaGTDTQKg7VodBATXgg== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsVy+t8zfd3vDR2BBvf2i1nMOd/CYnF54SVW i2MLxCyOnHnB7MDisWXlTSaPnbPusnv0bVnF6PF5k1wASxSXTUpqTmZZapG+XQJXxosl81gL bnBV3P9xj6WBsYWzi5GTQ0LARKL/7lwmCFtM4sK99WxdjFwcQgLLGCU2/73GBlN0efpSqMQi RoltNzazQDi/GCXOr3nGAlLFJqAm8eXLYfYuRg4OEQFdifnXTUDCzAI5Eh82PQErERYIk1i0 /TkriM0ioCpxeeocRhCbV8BSoqP7HzOELSjxY/I9FoheLYn1O48zQdjyEpvXvGWGOEhBYsfZ 12C9IgJ6Evvvt7BB1IhI7HvxjhHkNgmBTewS3TdPsEEsE5D4NvkQC8htEgKyEpsOQM2RlDi4 4gbLBEaxWUhWz0KyehaS1bOQrFjAyLKKUTS1ILmgOCm9yFSvODG3uDQvXS85P3cTIyTKJu5g vH/A+hBjMtD6icxSosn5wCjNK4k3NDYzsjA1MTU2Mrc0I01YSZxXvcU6UEggPbEkNTs1tSC1 KL6oNCe1+BAjEwenVANjiOKEsKxQddd3kX7HDcPFN+yufbLGqpHnSdOR31N7rnOucXsf+sW4 pa24Jjv0xDdPK6bjp8+aavssOPHkoIrDg9azL5if75u6okrmt6XX+VneCX2hWRofRV6UWixe EXR02xur0/LLuWft+qIiInJPOL5qwxLl+bPd83mPb7397/1Fqdj4MktPJZbijERDLeai4kQA yfctkcgCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEKsWRmVeSWpSXmKPExsVy+t9jAd3vDR2BBkd+C1nMOd/CYnF54SVW i2MLxCyOnHnB7MDisWXlTSaPnbPusnv0bVnF6PF5k1wAS1QDo01GamJKapFCal5yfkpmXrqt kndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0EolhbLEnFKgUEBicbGSvh2mCaEhbroW MI0Rur4hQXA9RgZoIGEdY8aLJfNYC25wVdz/cY+lgbGFs4uRk0NCwETi8vSlbBC2mMSFe+uB bC4OIYFFjBLbbmxmgXB+MUqcX/OMBaSKTUBN4suXw+xdjBwcIgK6EvOvm4CEmQVyJD5segJW IiwQJrFo+3NWEJtFQFXi8tQ5jCA2r4ClREf3P2YIW1Dix+R7LBC9WhLrdx5ngrDlJTavecsM cZCCxI6zr8F6RQT0JPbfb2GDqBGR2PfiHeMERoFZSEbNQjJqFpJRs5C0LGBkWcUomlqQXFCc lJ5rpFecmFtcmpeul5yfu4kRHMPPpHcwrmqwOMQowMGoxMOrcKo9UIg1say4MvcQowQHs5II r7R2R6AQb0piZVVqUX58UWlOavEhxmSgTycyS4km5wPTS15JvKGxiZmRpZGZhZGJuTlpwkri vAdbrQOFBNITS1KzU1MLUotgtjBxcEo1MHrOf+h0xmffupvrm8WW9rEa3VKvUFHr//mkhWVa pPKGW9lF2Tn9EUefvOsyU1Su6+z9sPiMNvuUwNUBZ72+Mzl+F49T25/70PZV0eSDe3Uv+6rf jty410oyUffhVN0763QFpr2zq3abvE3RlD2yP3lr+Iew2gTbrP9uPZli9y/2xs3O7xSsUmIp zkg01GIuKk4EAPzn1tQlAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/net/ethernet/adi/bfin_mac.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c index ee70577..7b8a1ee 100644 --- a/drivers/net/ethernet/adi/bfin_mac.c +++ b/drivers/net/ethernet/adi/bfin_mac.c @@ -1718,7 +1718,6 @@ out_err_mii_probe: mdiobus_unregister(lp->mii_bus); mdiobus_free(lp->mii_bus); out_err_probe_mac: - platform_set_drvdata(pdev, NULL); free_netdev(ndev); return rc; @@ -1731,8 +1730,6 @@ static int bfin_mac_remove(struct platform_device *pdev) bfin_phc_release(lp); - platform_set_drvdata(pdev, NULL); - lp->mii_bus->priv = NULL; unregister_netdev(ndev); @@ -1867,7 +1864,6 @@ static int bfin_mii_bus_remove(struct platform_device *pdev) struct bfin_mii_bus_platform_data *mii_bus_pd = dev_get_platdata(&pdev->dev); - platform_set_drvdata(pdev, NULL); mdiobus_unregister(miibus); kfree(miibus->irq); mdiobus_free(miibus);