From patchwork Tue May 7 00:56:35 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 241864 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id D66082C0104 for ; Tue, 7 May 2013 10:56:42 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZWCv-0005Mo-PL; Tue, 07 May 2013 00:56:41 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZWCp-0005Mi-Nu for fwts-devel@lists.ubuntu.com; Tue, 07 May 2013 00:56:35 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UZWCp-0000RG-Kf for fwts-devel@lists.ubuntu.com; Tue, 07 May 2013 00:56:35 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpi: acpidump: fix overflow before widening bug Date: Tue, 7 May 2013 01:56:35 +0100 Message-Id: <1367888195-25667-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.1.2 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Coverity CID#997275, Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) To avoid 32 bit overflow, cast info->bit_field_nbits to uint64_t before the shift. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Keng-Yu Lin --- src/acpi/acpidump/acpidump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/acpi/acpidump/acpidump.c b/src/acpi/acpidump/acpidump.c index 3bfbc2a..e509949 100644 --- a/src/acpi/acpidump/acpidump.c +++ b/src/acpi/acpidump/acpidump.c @@ -101,7 +101,7 @@ static void acpi_dump_str(fwts_framework *fw, fwts_acpidump_field *info, void *d static uint64_t apci_dump_get_uint64_t(fwts_acpidump_field *info, void *data) { uint64_t ret; - uint64_t mask = (1<bit_field_nbits) - 1; + uint64_t mask = (1<<(uint64_t)info->bit_field_nbits) - 1; int i; switch (info->size) {