From patchwork Mon May 6 23:41:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 241836 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id C8D592C00D2 for ; Tue, 7 May 2013 09:41:29 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZV28-0004Js-3m; Mon, 06 May 2013 23:41:28 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZV1z-0004JO-F9 for fwts-devel@lists.ubuntu.com; Mon, 06 May 2013 23:41:19 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UZV1z-00064T-BQ for fwts-devel@lists.ubuntu.com; Mon, 06 May 2013 23:41:19 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] cpu: cpufreq: avoid division by zero Date: Tue, 7 May 2013 00:41:18 +0100 Message-Id: <1367883678-22498-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.1.2 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Coverity CID #997299, Division or modulo by zero (DIVIDE_BY_ZERO) Avoid the very slim chance of a division by zero error. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/cpu/cpufreq/cpufreq.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/cpu/cpufreq/cpufreq.c b/src/cpu/cpufreq/cpufreq.c index df52100..e115bbb 100644 --- a/src/cpu/cpufreq/cpufreq.c +++ b/src/cpu/cpufreq/cpufreq.c @@ -169,7 +169,10 @@ static int get_performance_repeat( *retval = min; break; case GET_PERFORMANCE_AVG: - *retval = cumulative / real_count; + if (real_count) + *retval = cumulative / real_count; + else + *retval = 0; break; default: *retval = 0;