From patchwork Mon May 6 23:25:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 241829 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id D78492C0120 for ; Tue, 7 May 2013 09:25:17 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZUmR-0001DU-GJ; Mon, 06 May 2013 23:25:15 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZUmL-0001DF-5e for fwts-devel@lists.ubuntu.com; Mon, 06 May 2013 23:25:09 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UZUmK-0005SB-WC for fwts-devel@lists.ubuntu.com; Mon, 06 May 2013 23:25:09 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] lib: fwts_uefi: only close fp if it was successfully opened Date: Tue, 7 May 2013 00:25:08 +0100 Message-Id: <1367882708-21822-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.1.2 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Coverity CID #997293, Dereference after null check (FORWARD_NULL) Coverity caught a bug where we are closing fp even if it failed to open. Close it only if it opens correctly and fp is not NULL. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/lib/src/fwts_uefi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/src/fwts_uefi.c b/src/lib/src/fwts_uefi.c index 29cad80..f8678ab 100644 --- a/src/lib/src/fwts_uefi.c +++ b/src/lib/src/fwts_uefi.c @@ -107,8 +107,8 @@ static int fwts_uefi_get_interface(char **path) strcpy(efivar_path, "/sys/firmware/efi/vars"); } } + fclose(fp); } - fclose(fp); *path = NULL;