From patchwork Mon May 6 23:17:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 241828 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3E7D02C0120 for ; Tue, 7 May 2013 09:18:01 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZUfQ-0000lq-5f; Mon, 06 May 2013 23:18:00 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZUfK-0000ll-QB for fwts-devel@lists.ubuntu.com; Mon, 06 May 2013 23:17:54 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UZUfK-0005K5-N0 for fwts-devel@lists.ubuntu.com; Mon, 06 May 2013 23:17:54 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] lib: fwts_uefi: fix check of empty d_name Date: Tue, 7 May 2013 00:17:53 +0100 Message-Id: <1367882273-21613-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.1.2 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Coverity CID #997279, Array compared against 0 (NO_EFFECT) Fix bug where we are comparing d_name against NULL; should be in fact checking if first char is '\0'. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/lib/src/fwts_uefi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/src/fwts_uefi.c b/src/lib/src/fwts_uefi.c index 16ae1da..29cad80 100644 --- a/src/lib/src/fwts_uefi.c +++ b/src/lib/src/fwts_uefi.c @@ -399,7 +399,7 @@ int fwts_uefi_get_variable_names(fwts_list *list) return FWTS_ERROR; for (i = 0; i < n; i++) { - if (names[i]->d_name == NULL) + if (names[i]->d_name[0] == '\0') continue; if (!strcmp(names[i]->d_name, ".")) continue;