From patchwork Mon May 6 23:00:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 241814 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id F15572C009E for ; Tue, 7 May 2013 09:00:52 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZUOo-00075m-P4; Mon, 06 May 2013 23:00:50 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZUOj-000742-Iq for fwts-devel@lists.ubuntu.com; Mon, 06 May 2013 23:00:45 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UZUOj-0004fb-Ai for fwts-devel@lists.ubuntu.com; Mon, 06 May 2013 23:00:45 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpi: s3: free quirks and command resources Date: Tue, 7 May 2013 00:00:44 +0100 Message-Id: <1367881244-20843-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.1.2 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Coverity CID #997264, Resource leak. Need to free quirks and command before we return. Signed-off-by: Colin Ian King --- src/acpi/s3/s3.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/acpi/s3/s3.c b/src/acpi/s3/s3.c index ae89423..7528ec2 100644 --- a/src/acpi/s3/s3.c +++ b/src/acpi/s3/s3.c @@ -73,8 +73,8 @@ static int s3_do_suspend_resume(fwts_framework *fw, int differences; time_t t_start; time_t t_end; - char *command; - char *quirks; + char *command = NULL; + char *quirks = NULL; char buffer[80]; fwts_klog_clear(); @@ -183,6 +183,11 @@ static int s3_do_suspend_resume(fwts_framework *fw, fwts_tag_failed(fw, FWTS_TAG_POWER_MANAGEMENT); } + if (command) + free(command); + if (quirks) + free(quirks); + return FWTS_OK; }