From patchwork Mon May 6 21:53:39 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 241799 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 7F6522C00B2 for ; Tue, 7 May 2013 07:53:46 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZTLt-00063R-De; Mon, 06 May 2013 21:53:45 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UZTLo-00063H-8b for fwts-devel@lists.ubuntu.com; Mon, 06 May 2013 21:53:40 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UZTLo-0002Jt-5O for fwts-devel@lists.ubuntu.com; Mon, 06 May 2013 21:53:40 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] lib: fwts_memorymap: free klog on error Date: Mon, 6 May 2013 22:53:39 +0100 Message-Id: <1367877219-17142-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.1.2 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Coverity CID #997341, Resource leak. Need to free klog list before we return. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/lib/src/fwts_memorymap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/lib/src/fwts_memorymap.c b/src/lib/src/fwts_memorymap.c index 2988e5b..6e8bc1e 100644 --- a/src/lib/src/fwts_memorymap.c +++ b/src/lib/src/fwts_memorymap.c @@ -233,8 +233,10 @@ fwts_list *fwts_memory_map_table_load_from_klog(fwts_framework *fw) if ((klog = fwts_klog_read()) == NULL) return NULL; - if ((memory_map_list = fwts_list_new()) == NULL) + if ((memory_map_list = fwts_list_new()) == NULL) { + fwts_klog_free(klog); return NULL; + } fwts_list_iterate(klog, fwts_memory_map_dmesg_info, memory_map_list); fwts_klog_free(klog);