From patchwork Mon May 6 19:25:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 241760 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 3BD232C00AE for ; Tue, 7 May 2013 05:25:28 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=ovDzZcC2SQTeDVj9f 3wuEGq7D5Pto9S4hAjP0SoxEizcVlQUE6F0uD+4d6V32fIS3FUzMonH1Hx5SkSly XFcuLjI0Sn6cwZ1qRyvk7hJ0xiIW/EfdBypmD1BDGB9Wv4EleRwFG3viVdlONUKs X0WmUKEGkC2WJ9fFO3m3bBz6NU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to; s=default; bh=IZ6bxtLYKTLJO9ltQwJ+yE4 kZMw=; b=kd1KxR07IcyHFwX+wEuSHCv4nOkfPHf6b2l44+egLc3ycRpqk3hOxaw rvhU+gxlRdVQEBbXHOJnUKn3FWEKq3LknVJlyXNIpVhHXWxgQwg9ntOCpkLUWUwK 0T7g6ZR3pCF9NfHVsFx2rrmnjD9uR4F6o33nYMR+dKjJKuQdgma0= Received: (qmail 911 invoked by alias); 6 May 2013 19:25:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 894 invoked by uid 89); 6 May 2013 19:25:19 -0000 X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL, BAYES_00, RCVD_IN_HOSTKARMA_W, RCVD_IN_HOSTKARMA_WL, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS, TW_OV autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 06 May 2013 19:25:15 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r46JPEQb014396 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 May 2013 15:25:14 -0400 Received: from zalov.cz (vpn-57-147.rdu2.redhat.com [10.10.57.147]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r46JPC8Y021526 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 6 May 2013 15:25:13 -0400 Received: from zalov.cz (localhost [127.0.0.1]) by zalov.cz (8.14.5/8.14.5) with ESMTP id r46JPADM009038; Mon, 6 May 2013 21:25:10 +0200 Received: (from jakub@localhost) by zalov.cz (8.14.5/8.14.5/Submit) id r46JP7Vv009037; Mon, 6 May 2013 21:25:07 +0200 Date: Mon, 6 May 2013 21:25:06 +0200 From: Jakub Jelinek To: Bill Schmidt Cc: gcc-patches@gcc.gnu.org, richard.guenther@gmail.com, bergner@vnet.ibm.com Subject: Re: [PATCH] Fix thinko in SLSR that caused x86 bootstrap failure Message-ID: <20130506192506.GQ28963@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <1367786717.11638.58.camel@gnopaine> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1367786717.11638.58.camel@gnopaine> User-Agent: Mutt/1.5.21 (2010-09-15) On Sun, May 05, 2013 at 03:45:17PM -0500, Bill Schmidt wrote: > 2013-05-05 Bill Schmidt > > * gimple-ssa-strength-reduction.c (slsr_process_phi): Re-enable. > (find_candidates_in_block): Re-enable slsr_process_phi. > (create_phi_basis): Fix double counting of candidate adjustment. This broke gcc.dg/pr33017.c testcase on i?86/x86_64 -m32. ./cc1 -O2 -ftree-vectorize -m32 -mno-sse pr33017.c difference between r19862{6,7} is: Jakub --- pr33017.s1 2013-05-06 21:22:03.786745422 +0200 +++ pr33017.s2 2013-05-06 21:22:16.844673015 +0200 @@ -32,9 +32,9 @@ foo: movb $87, var.1373+2(%eax) je .L10 cmpl $3, %edx - movb $87, var.1373+3(%eax) + movb $87, var.1373+2(%eax,%eax) jne .L11 - movb $87, var.1373+4(%eax) + movb $87, var.1373+2(%eax,%eax,2) movl $3, %ebp movl $61, 28(%esp) .L3: