From patchwork Mon May 6 16:07:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 241715 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 258A82C00F0 for ; Tue, 7 May 2013 02:08:02 +1000 (EST) Received: from localhost ([::1]:60862 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZNxI-0003QB-4m for incoming@patchwork.ozlabs.org; Mon, 06 May 2013 12:08:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZNww-0003P0-Hm for qemu-devel@nongnu.org; Mon, 06 May 2013 12:07:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZNwr-0008Ci-Iw for qemu-devel@nongnu.org; Mon, 06 May 2013 12:07:38 -0400 Received: from thoth.sbs.de ([192.35.17.2]:19821) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZNwR-00088S-By; Mon, 06 May 2013 12:07:07 -0400 Received: from mail1.siemens.de (localhost [127.0.0.1]) by thoth.sbs.de (8.13.6/8.13.6) with ESMTP id r46G75BQ010263; Mon, 6 May 2013 18:07:05 +0200 Received: from mchn199C.mchp.siemens.de ([139.25.109.49]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id r46G75ED006677; Mon, 6 May 2013 18:07:05 +0200 Message-ID: <5187D529.7010502@siemens.com> Date: Mon, 06 May 2013 18:07:05 +0200 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: qemu-trivial X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 192.35.17.2 Cc: qemu-devel Subject: [Qemu-devel] [PATCH] memory: Replace open-coded memory_region_is_romd X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Improves readability. Signed-off-by: Jan Kiszka Reviewed-by: Peter Maydell --- translate-all.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/translate-all.c b/translate-all.c index da93608..0d84b0d 100644 --- a/translate-all.c +++ b/translate-all.c @@ -1359,7 +1359,7 @@ void tb_invalidate_phys_addr(hwaddr addr) section = phys_page_find(address_space_memory.dispatch, addr >> TARGET_PAGE_BITS); if (!(memory_region_is_ram(section->mr) - || (section->mr->rom_device && section->mr->readable))) { + || memory_region_is_romd(section->mr))) { return; } ram_addr = (memory_region_get_ram_addr(section->mr) & TARGET_PAGE_MASK)