Patchwork [U-Boot,RFC] patman: Do not hardcode python path

login
register
mail settings
Submitter Michal Simek
Date May 6, 2013, 2:11 p.m.
Message ID <1e17aa12ee889859a17d2481b5142de30cfa660e.1367849513.git.michal.simek@xilinx.com>
Download mbox | patch
Permalink /patch/241683/
State Accepted, archived
Delegated to: Simon Glass
Headers show

Comments

Michal Simek - May 6, 2013, 2:11 p.m.
Patman requires python 2.7.4 to run but it doesn't
need to be placed in /usr/bin/python.
Use env to ensure that the interpreter used is
the first one on environment's $PATH on system
with several versions of Python installed.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
 tools/patman/patman.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
1.8.2.1
Tom Rini - May 6, 2013, 2:14 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/06/2013 10:11 AM, Michal Simek wrote:
> Patman requires python 2.7.4 to run but it doesn't need to be
> placed in /usr/bin/python. Use env to ensure that the interpreter
> used is the first one on environment's $PATH on system with several
> versions of Python installed.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- 
> tools/patman/patman.py | 2 +- 1 file changed, 1 insertion(+), 1
> deletion(-)
> 
> diff --git a/tools/patman/patman.py b/tools/patman/patman.py index
> a8061a9..7a317c5 100755 --- a/tools/patman/patman.py +++
> b/tools/patman/patman.py @@ -1,4 +1,4 @@ -#!/usr/bin/python 
> +#!/usr/bin/env python # # Copyright (c) 2011 The Chromium OS
> Authors. #

Reviewed-by: Tom Rini <trini@ti.com>

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRh7q0AAoJENk4IS6UOR1Wd50QAICcAr93mMDbGeSdnw4ve3+H
4JvdRPbrmEkDbp/8hl9LYtSgeHZKX80QW4g+A+pvzOlhrESZqnFD3qCX54BUajlF
7YjgslhGYaofYtJFPz/3j5vl4kvykAoCrZTYDSNONTlw/Bl+4QKhPdeaKmNYBRm+
8UIgABLyfcT/l7y3B9NZUEbsElsyIL2MKf/xZ47EBbl3a0uOFLFI0hOIqazIIbak
2BSs5UY+aA9sLCKQnddKkz8gPgCjZE9qLUfKdClI1VBn+f0YdkyX0H6eJN0nNOGM
MSYP7d/fgVI6aGZgZ/l1ZQffOK8c4Ryo/CVUEaHtVJQzQXoBqVlnEwWULZWIIQrP
PeC+Vrgcug/ZFdiHdOnaXjrWW6H5j2//uDg9iCkVYVjSdMAwClP0FEaQlpt8th8j
HFFspFqoQfDRPu2DufmZv+tzmsmkRUZNQuUn3g87b1Z+d2WvMrBB6X2NwEf8977c
djw6WmzmesoT0RZxChb7yXmUKl06qkFfyIChYDru0mJW9D32fMfqjqpo3XFrrNML
w25MCBVvONyIwNtBeeVUb5Jj/npX58v9uuTv3B3YRGBHFlXwLcoog0gnN5msMRS5
jO+5JyV0kFeSXc/VKP1H8kY4suAieUF/10s6OnzAUlZu12jhTmfhax0IDrXudbq3
UXrn3T92b7I5yPg/NbQ2
=nSTp
-----END PGP SIGNATURE-----
Simon Glass - May 6, 2013, 7:03 p.m.
On Mon, May 6, 2013 at 8:14 AM, Tom Rini <trini@ti.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 05/06/2013 10:11 AM, Michal Simek wrote:
>> Patman requires python 2.7.4 to run but it doesn't need to be
>> placed in /usr/bin/python. Use env to ensure that the interpreter
>> used is the first one on environment's $PATH on system with several
>> versions of Python installed.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> ---
>> tools/patman/patman.py | 2 +- 1 file changed, 1 insertion(+), 1
>> deletion(-)
>>
>> diff --git a/tools/patman/patman.py b/tools/patman/patman.py index
>> a8061a9..7a317c5 100755 --- a/tools/patman/patman.py +++
>> b/tools/patman/patman.py @@ -1,4 +1,4 @@ -#!/usr/bin/python
>> +#!/usr/bin/env python # # Copyright (c) 2011 The Chromium OS
>> Authors. #
>
> Reviewed-by: Tom Rini <trini@ti.com>

Acked-by: Simon Glass <sjg@chromium.org>
Simon Glass - May 13, 2013, 2:27 a.m.
On Mon, May 6, 2013 at 1:03 PM, Simon Glass <sjg@chromium.org> wrote:
> On Mon, May 6, 2013 at 8:14 AM, Tom Rini <trini@ti.com> wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 05/06/2013 10:11 AM, Michal Simek wrote:
>>> Patman requires python 2.7.4 to run but it doesn't need to be
>>> placed in /usr/bin/python. Use env to ensure that the interpreter
>>> used is the first one on environment's $PATH on system with several
>>> versions of Python installed.
>>>
>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> ---
>>> tools/patman/patman.py | 2 +- 1 file changed, 1 insertion(+), 1
>>> deletion(-)
>>>
>>> diff --git a/tools/patman/patman.py b/tools/patman/patman.py index
>>> a8061a9..7a317c5 100755 --- a/tools/patman/patman.py +++
>>> b/tools/patman/patman.py @@ -1,4 +1,4 @@ -#!/usr/bin/python
>>> +#!/usr/bin/env python # # Copyright (c) 2011 The Chromium OS
>>> Authors. #
>>
>> Reviewed-by: Tom Rini <trini@ti.com>
>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to x86/patman.

Patch

diff --git a/tools/patman/patman.py b/tools/patman/patman.py
index a8061a9..7a317c5 100755
--- a/tools/patman/patman.py
+++ b/tools/patman/patman.py
@@ -1,4 +1,4 @@ 
-#!/usr/bin/python
+#!/usr/bin/env python
 #
 # Copyright (c) 2011 The Chromium OS Authors.
 #