From patchwork Mon May 6 13:11:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Libo Chen X-Patchwork-Id: 241643 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 360592C00EE for ; Mon, 6 May 2013 23:12:39 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753754Ab3EFNMV (ORCPT ); Mon, 6 May 2013 09:12:21 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:17843 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753642Ab3EFNMT (ORCPT ); Mon, 6 May 2013 09:12:19 -0400 Received: from 172.24.2.119 (EHLO szxeml209-edg.china.huawei.com) ([172.24.2.119]) by szxrg02-dlp.huawei.com (MOS 4.3.4-GA FastPath queued) with ESMTP id BBD53842; Mon, 06 May 2013 21:12:18 +0800 (CST) Received: from SZXEML456-HUB.china.huawei.com (10.82.67.199) by szxeml209-edg.china.huawei.com (172.24.2.184) with Microsoft SMTP Server (TLS) id 14.1.323.7; Mon, 6 May 2013 21:11:28 +0800 Received: from [127.0.0.1] (10.135.72.158) by szxeml456-hub.china.huawei.com (10.82.67.199) with Microsoft SMTP Server id 14.1.323.7; Mon, 6 May 2013 21:11:20 +0800 Message-ID: <5187ABF6.4000907@huawei.com> Date: Mon, 6 May 2013 21:11:18 +0800 From: Libo Chen User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: CC: , , , Li Zefan Subject: [PATCH 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it`s init successful X-Originating-IP: [10.135.72.158] X-CFilter-Loop: Reflected Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org down out_error_no_irq. When platform_get_irq fail, no need to free peripheral Signed-off-by: Libo Chen --- drivers/i2c/busses/i2c-bfin-twi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c index 05080c4..d38e05a 100644 --- a/drivers/i2c/busses/i2c-bfin-twi.c +++ b/drivers/i2c/busses/i2c-bfin-twi.c @@ -709,8 +709,8 @@ static int i2c_bfin_twi_probe(struct platform_device *pdev) out_error_add_adapter: free_irq(iface->irq, iface); out_error_req_irq: -out_error_no_irq: peripheral_free_list((unsigned short *)pdev->dev.platform_data); +out_error_no_irq: out_error_pin_mux: iounmap(iface->regs_base); out_error_ioremap: