Patchwork [1/2] i2c: i2c-bfin-twi: don`t free peripheral before it`s init successful

login
register
mail settings
Submitter Libo Chen
Date May 6, 2013, 1:11 p.m.
Message ID <5187ABF6.4000907@huawei.com>
Download mbox | patch
Permalink /patch/241643/
State Superseded
Headers show

Comments

Libo Chen - May 6, 2013, 1:11 p.m.
down out_error_no_irq. When platform_get_irq fail, no need to free peripheral

Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
 drivers/i2c/busses/i2c-bfin-twi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Zhang, Sonic - May 9, 2013, 5:07 a.m.
Hi Libo,

>-----Original Message-----
>From: uclinux-dist-devel-bounces@blackfin.uclinux.org [mailto:uclinux-dist-devel-
>bounces@blackfin.uclinux.org] On Behalf Of Libo Chen
>Sent: Monday, May 06, 2013 9:11 PM
>To: wsa@the-dreams.de
>Cc: uclinux-dist-devel@blackfin.uclinux.org; Li Zefan; linux-i2c@vger.kernel.org;
>linux-kernel@vger.kernel.org
>Subject: [uclinux-dist-devel] [PATCH 1/2] i2c: i2c-bfin-twi: don`t free peripheral
>before it`s init successful
>
>
>down out_error_no_irq. When platform_get_irq fail, no need to free peripheral
>
>Signed-off-by: Libo Chen <libo.chen@huawei.com>
>---
> drivers/i2c/busses/i2c-bfin-twi.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c
>index 05080c4..d38e05a 100644
>--- a/drivers/i2c/busses/i2c-bfin-twi.c
>+++ b/drivers/i2c/busses/i2c-bfin-twi.c
>@@ -709,8 +709,8 @@ static int i2c_bfin_twi_probe(struct platform_device *pdev)
> out_error_add_adapter:
>       free_irq(iface->irq, iface);
> out_error_req_irq:
>-out_error_no_irq:
>       peripheral_free_list((unsigned short *)pdev->dev.platform_data);
>+out_error_no_irq:
> out_error_pin_mux:
>       iounmap(iface->regs_base);
> out_error_ioremap:

You should exchange line out_error_no_irq: and line out_error_pin_mux: other than.
Could you send me a new patch?

Regards,

Sonic

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c
index 05080c4..d38e05a 100644
--- a/drivers/i2c/busses/i2c-bfin-twi.c
+++ b/drivers/i2c/busses/i2c-bfin-twi.c
@@ -709,8 +709,8 @@  static int i2c_bfin_twi_probe(struct platform_device *pdev)
 out_error_add_adapter:
 	free_irq(iface->irq, iface);
 out_error_req_irq:
-out_error_no_irq:
 	peripheral_free_list((unsigned short *)pdev->dev.platform_data);
+out_error_no_irq:
 out_error_pin_mux:
 	iounmap(iface->regs_base);
 out_error_ioremap: