Patchwork [U-Boot] arm/km: fix u-boot update functionality

login
register
mail settings
Submitter Holger Brunck
Date May 6, 2013, 12:54 p.m.
Message ID <1367844878-14416-1-git-send-email-holger.brunck@keymile.com>
Download mbox | patch
Permalink /patch/241636/
State Superseded
Delegated to: Heiko Schocher
Headers show

Comments

Holger Brunck - May 6, 2013, 12:54 p.m.
Due to the new I2C framework we need to adapt the u-boot update
function. Due to the new framework all i2c leafs behind a mux are
present in the system and not only those who are defined and used. So it
is bus number 5 after the rework.

Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
cc: Heiko Schocher <hs@denx.de>
cc: Prafulla Wadaskar <prafulla@marvell.com>
---
This patch is dependent to the already posted patchserie:
http://lists.denx.de/pipermail/u-boot/2013-May/153452.html

 include/configs/km/km_arm.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Heiko Schocher - May 6, 2013, 2:02 p.m.
Hello Prafulla,

Am 06.05.2013 14:54, schrieb Holger Brunck:
> Due to the new I2C framework we need to adapt the u-boot update
> function. Due to the new framework all i2c leafs behind a mux are
> present in the system and not only those who are defined and used. So it
> is bus number 5 after the rework.
> 
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> cc: Heiko Schocher <hs@denx.de>
> cc: Prafulla Wadaskar <prafulla@marvell.com>
> ---
> This patch is dependent to the already posted patchserie:
> http://lists.denx.de/pipermail/u-boot/2013-May/153452.html
> 
>  include/configs/km/km_arm.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

I added this patch to my ToDo List in Patchwork, if it is OK
for you?

bye,
Heiko
Prafulla Wadaskar - May 7, 2013, 3:52 a.m.
> -----Original Message-----
> From: Heiko Schocher [mailto:hs@denx.de]
> Sent: 06 May 2013 19:32
> To: Holger Brunck
> Cc: u-boot@lists.denx.de; Prafulla Wadaskar
> Subject: Re: [PATCH] arm/km: fix u-boot update
> functionality
> 
> Hello Prafulla,
> 
> Am 06.05.2013 14:54, schrieb Holger Brunck:
> > Due to the new I2C framework we need to adapt the u-
> boot update
> > function. Due to the new framework all i2c leafs
> behind a mux are
> > present in the system and not only those who are
> defined and used. So it
> > is bus number 5 after the rework.
> >
> > Signed-off-by: Holger Brunck
> <holger.brunck@keymile.com>
> > cc: Heiko Schocher <hs@denx.de>
> > cc: Prafulla Wadaskar <prafulla@marvell.com>
> > ---
> > This patch is dependent to the already posted
> patchserie:
> > http://lists.denx.de/pipermail/u-boot/2013-
> May/153452.html
> >
> >  include/configs/km/km_arm.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> I added this patch to my ToDo List in Patchwork, if it
> is OK
> for you?

Dear Heiko
That should be okay, no issues, please go ahead.

Regards...
Prafulla . . .

Patch

diff --git a/include/configs/km/km_arm.h b/include/configs/km/km_arm.h
index ebbfa84..4da54d5 100644
--- a/include/configs/km/km_arm.h
+++ b/include/configs/km/km_arm.h
@@ -295,7 +295,8 @@  int get_scl(void);
 #else
 #define CONFIG_KM_NEW_ENV						\
 	"newenv=setenv addr 0x100000 && "				\
-		"i2c dev 1; mw.b ${addr} 0 4 && "			\
+		"i2c dev " __stringify(CONFIG_I2C_ENV_EEPROM_BUS) "; "  \
+		"mw.b ${addr} 0 4 && "					\
 		"eeprom write " __stringify(CONFIG_SYS_DEF_EEPROM_ADDR)	\
 		" ${addr} " __stringify(CONFIG_ENV_OFFSET) " 4 && "	\
 		"eeprom write " __stringify(CONFIG_SYS_DEF_EEPROM_ADDR)	\