Patchwork [U-Boot] Powerpc/esdhc: Correct judgement for DATA PIO mode

login
register
mail settings
Submitter Haijun.Zhang
Date May 6, 2013, 6:23 a.m.
Message ID <1367821417-31096-1-git-send-email-Haijun.Zhang@freescale.com>
Download mbox | patch
Permalink /patch/241601/
State Changes Requested
Delegated to: Andy Fleming
Headers show

Comments

Haijun.Zhang - May 6, 2013, 6:23 a.m.
From: "Haijun.Zhang" <Haijun.Zhang@freescale.com>

The logic for the whether to configure for polling or DMA
was mistakenly reversed in this patch:

Commit 7b43db92110ec2f15c5f7187a165f2928464966b
drivers/mmc/fsl_esdhc.c: fix compiler warnings

Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
CC: Sun Yusong-R58495 <yorksun@freescale.com>
CC: Fleming Andrew-AFLEMING <AFLEMING@freescale.com>
---
 drivers/mmc/fsl_esdhc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Andy Fleming - May 6, 2013, 3:46 p.m.
I'm confused. The patch you submitted internally was totally different.


On Mon, May 6, 2013 at 1:23 AM, Haijun.Zhang <Haijun.Zhang@freescale.com>wrote:

> From: "Haijun.Zhang" <Haijun.Zhang@freescale.com>
>
> The logic for the whether to configure for polling or DMA
> was mistakenly reversed in this patch:
>
> Commit 7b43db92110ec2f15c5f7187a165f2928464966b
> drivers/mmc/fsl_esdhc.c: fix compiler warnings
>



> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> index e93e38a..8feb3d3 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -74,7 +74,7 @@ static uint esdhc_xfertyp(struct mmc_cmd *cmd, struct
> mmc_data *data)
>
>         if (data) {
>                 xfertyp |= XFERTYP_DPSEL;
> -#ifndef CONFIG_SYS_FSL_ESDHC_USE_PIO
> +#ifdef CONFIG_SYS_FSL_ESDHC_USE_PIO
>                 xfertyp |= XFERTYP_DMAEN;
>  #endif
>


This logic is correct, as it is. PIO means NOT DMA. The original patch you
sent corrected this part:

#ifndef CONFIG_SYS_FSL_ESDHC_USE_PIO

in esdhc_setup_data. This patch seems to just break things further?

Andy

Patch

diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
index e93e38a..8feb3d3 100644
--- a/drivers/mmc/fsl_esdhc.c
+++ b/drivers/mmc/fsl_esdhc.c
@@ -74,7 +74,7 @@  static uint esdhc_xfertyp(struct mmc_cmd *cmd, struct mmc_data *data)
 
 	if (data) {
 		xfertyp |= XFERTYP_DPSEL;
-#ifndef CONFIG_SYS_FSL_ESDHC_USE_PIO
+#ifdef CONFIG_SYS_FSL_ESDHC_USE_PIO
 		xfertyp |= XFERTYP_DMAEN;
 #endif
 		if (data->blocks > 1) {