Patchwork [v8,7/7] package: Introduce NOMMU symbol

login
register
mail settings
Submitter Sonic Zhang
Date May 6, 2013, 7:35 a.m.
Message ID <1367825740-9408-2-git-send-email-sonic.adi@gmail.com>
Download mbox | patch
Permalink /patch/241600/
State Rejected
Headers show

Comments

Sonic Zhang - May 6, 2013, 7:35 a.m.
From: Sonic Zhang <sonic.zhang@analog.com>

Introduce NOMMU symbol __NOMMU__

---
v6-changes:
- Remove space between comma and y.
- Restore endif after rebase.

Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
---
 package/Makefile.in |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Sonic Zhang - May 14, 2013, 6:23 a.m.
Hi Thomas,

On Mon, May 6, 2013 at 3:35 PM, Sonic Zhang <sonic.adi@gmail.com> wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> Introduce NOMMU symbol __NOMMU__
>
> ---
> v6-changes:
> - Remove space between comma and y.
> - Restore endif after rebase.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> ---
>  package/Makefile.in |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/package/Makefile.in b/package/Makefile.in
> index a449089..55d725d 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -107,6 +107,10 @@ ifeq ($(BR2_BINFMT_FLAT),y)
>  TARGET_LDFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt=-s$($(PKG)_FLAT_STACKSIZE))
>  endif
>
> +ifneq ($(BR2_USE_MMU),y)
> +TARGET_CFLAGS += -D__NOMMU__
> +endif
> +
>  ifeq ($(BR2_BINFMT_FLAT_SHARED),y)
>  TARGET_LDFLAGS += -mid-shared-library -mshared-library-id=0
>  TARGET_CFLAGS += -mid-shared-library -mshared-library-id=0
> --

May I have your Acked-by for the last 2 bfin arch support patches?

Regards,

Sonic
Thomas Petazzoni - May 14, 2013, 7:15 a.m.
Dear Sonic Zhang,

On Tue, 14 May 2013 14:23:11 +0800, Sonic Zhang wrote:

> > diff --git a/package/Makefile.in b/package/Makefile.in
> > index a449089..55d725d 100644
> > --- a/package/Makefile.in
> > +++ b/package/Makefile.in
> > @@ -107,6 +107,10 @@ ifeq ($(BR2_BINFMT_FLAT),y)
> >  TARGET_LDFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt=-s$($(PKG)_FLAT_STACKSIZE))
> >  endif
> >
> > +ifneq ($(BR2_USE_MMU),y)
> > +TARGET_CFLAGS += -D__NOMMU__
> > +endif
> > +
> >  ifeq ($(BR2_BINFMT_FLAT_SHARED),y)
> >  TARGET_LDFLAGS += -mid-shared-library -mshared-library-id=0
> >  TARGET_CFLAGS += -mid-shared-library -mshared-library-id=0
> > --
> 
> May I have your Acked-by for the last 2 bfin arch support patches?

For the 2013.05 cycle, it is now too late to get functional patches in,
Peter is now only taking fixes. Though we can continue the work and get
them merged in -next.

Regarding this patch specifically (PATCH 7/7), I have never been happy
with it, because I don't like the idea of passing globally this
-D__NOMMU__ symbol all around, while it's not a standard symbol.

I've asked Peter, and he agrees with this position. Therefore, what we
would like to see is -D__NOMMU__ added only to those packages that
actually need it.

Regarding PATCH 6/7, since the 2013.05 cycle is over for new patches, I
was hoping to find some time to look and it and refactor it. But I
believe I'll just test it once again, give my Acked-by: so it gets
merged, and then later on find the time to refactor it.

Would this be ok for you?

Also, while we're at it, I've just launched a new version of our
autobuilders infrastructure (see
http://lists.busybox.net/pipermail/buildroot/2013-May/072143.html).
Would you be interested in receiving a daily e-mail that contains only
the list of Blackfin related build failures?

Best regards,

Thomas
Sonic Zhang - May 14, 2013, 7:28 a.m.
Hi Thomas,

On Tue, May 14, 2013 at 3:15 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Sonic Zhang,
>
> On Tue, 14 May 2013 14:23:11 +0800, Sonic Zhang wrote:
>
>> > diff --git a/package/Makefile.in b/package/Makefile.in
>> > index a449089..55d725d 100644
>> > --- a/package/Makefile.in
>> > +++ b/package/Makefile.in
>> > @@ -107,6 +107,10 @@ ifeq ($(BR2_BINFMT_FLAT),y)
>> >  TARGET_LDFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt=-s$($(PKG)_FLAT_STACKSIZE))
>> >  endif
>> >
>> > +ifneq ($(BR2_USE_MMU),y)
>> > +TARGET_CFLAGS += -D__NOMMU__
>> > +endif
>> > +
>> >  ifeq ($(BR2_BINFMT_FLAT_SHARED),y)
>> >  TARGET_LDFLAGS += -mid-shared-library -mshared-library-id=0
>> >  TARGET_CFLAGS += -mid-shared-library -mshared-library-id=0
>> > --
>>
>> May I have your Acked-by for the last 2 bfin arch support patches?
>
> For the 2013.05 cycle, it is now too late to get functional patches in,
> Peter is now only taking fixes. Though we can continue the work and get
> them merged in -next.
>
> Regarding this patch specifically (PATCH 7/7), I have never been happy
> with it, because I don't like the idea of passing globally this
> -D__NOMMU__ symbol all around, while it's not a standard symbol.
>
> I've asked Peter, and he agrees with this position. Therefore, what we
> would like to see is -D__NOMMU__ added only to those packages that
> actually need it.
>

OK. This is fine to me.

> Regarding PATCH 6/7, since the 2013.05 cycle is over for new patches, I
> was hoping to find some time to look and it and refactor it. But I
> believe I'll just test it once again, give my Acked-by: so it gets
> merged, and then later on find the time to refactor it.
>
> Would this be ok for you?
>

Yes, having your Acked-by for -next tree is good enough.

> Also, while we're at it, I've just launched a new version of our
> autobuilders infrastructure (see
> http://lists.busybox.net/pipermail/buildroot/2013-May/072143.html).
> Would you be interested in receiving a daily e-mail that contains only
> the list of Blackfin related build failures?

I am find to receive these notify email by my gmail account.

Regards,

Sonic
Thomas Petazzoni - May 14, 2013, 7:30 a.m.
Dear Sonic Zhang,

On Tue, 14 May 2013 15:28:23 +0800, Sonic Zhang wrote:

> > For the 2013.05 cycle, it is now too late to get functional patches in,
> > Peter is now only taking fixes. Though we can continue the work and get
> > them merged in -next.
> >
> > Regarding this patch specifically (PATCH 7/7), I have never been happy
> > with it, because I don't like the idea of passing globally this
> > -D__NOMMU__ symbol all around, while it's not a standard symbol.
> >
> > I've asked Peter, and he agrees with this position. Therefore, what we
> > would like to see is -D__NOMMU__ added only to those packages that
> > actually need it.
> 
> OK. This is fine to me.

Thanks. Of course, this is our current position. Depending on how many
packages are affected, and how things turn out to work, we may decide
otherwise in the future. But for now, we'd prefer to have it on a
per-package basis to really understand which packages are affected by
that.

> > Regarding PATCH 6/7, since the 2013.05 cycle is over for new patches, I
> > was hoping to find some time to look and it and refactor it. But I
> > believe I'll just test it once again, give my Acked-by: so it gets
> > merged, and then later on find the time to refactor it.
> >
> > Would this be ok for you?
> 
> Yes, having your Acked-by for -next tree is good enough.

Ok, so I'll work on testing your patch as is.

> > Also, while we're at it, I've just launched a new version of our
> > autobuilders infrastructure (see
> > http://lists.busybox.net/pipermail/buildroot/2013-May/072143.html).
> > Would you be interested in receiving a daily e-mail that contains only
> > the list of Blackfin related build failures?
> 
> I am find to receive these notify email by my gmail account.

Ok, will do so.

Thanks,

Thomas

Patch

diff --git a/package/Makefile.in b/package/Makefile.in
index a449089..55d725d 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -107,6 +107,10 @@  ifeq ($(BR2_BINFMT_FLAT),y)
 TARGET_LDFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt=-s$($(PKG)_FLAT_STACKSIZE))
 endif
 
+ifneq ($(BR2_USE_MMU),y)
+TARGET_CFLAGS += -D__NOMMU__
+endif
+
 ifeq ($(BR2_BINFMT_FLAT_SHARED),y)
 TARGET_LDFLAGS += -mid-shared-library -mshared-library-id=0
 TARGET_CFLAGS += -mid-shared-library -mshared-library-id=0