Patchwork [v3,3/5] pflash_cfi01: memory region should be set to enable readonly mode

login
register
mail settings
Submitter jordan.l.justen@intel.com
Date May 6, 2013, 7:23 a.m.
Message ID <1367825026-3146-4-git-send-email-jordan.l.justen@intel.com>
Download mbox | patch
Permalink /patch/241584/
State New
Headers show

Comments

jordan.l.justen@intel.com - May 6, 2013, 7:23 a.m.
This causes any writes to the memory region to trap to the
device handler.

This is also important for KVM, because this allows the memory
region to be set using KVM_MEM_READONLY, which allows the memory
region to be read & executed. (Without this, KVM will not support
executing from the memory region.)

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
---
 hw/block/pflash_cfi01.c |    2 ++
 1 file changed, 2 insertions(+)

Patch

diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
index 3ff20e0..b65225e 100644
--- a/hw/block/pflash_cfi01.c
+++ b/hw/block/pflash_cfi01.c
@@ -596,6 +596,8 @@  static int pflash_cfi01_init(SysBusDevice *dev)
         }
     }
 
+    memory_region_set_readonly(&pfl->mem, true);
+
     if (pfl->bs) {
         pfl->ro = bdrv_is_read_only(pfl->bs);
     } else {