Patchwork powerpc/cell/spufs: Fix status attribute permission

login
register
mail settings
Submitter Benjamin Herrenschmidt
Date May 6, 2013, 6:42 a.m.
Message ID <1367822556.15842.13.camel@pasglop>
Download mbox | patch
Permalink /patch/241563/
State Accepted, archived
Commit 96cf3f66debbff7bc880ea747c10eef2d977a6fe
Headers show

Comments

Benjamin Herrenschmidt - May 6, 2013, 6:42 a.m.
We are registering the attribute with permission 0644 but it
doesn't have a store callback, which causes WARN_ON's during
boot. Fix the permission.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
 arch/powerpc/platforms/cell/spu_base.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c
index 8b12139..f85db3a 100644
--- a/arch/powerpc/platforms/cell/spu_base.c
+++ b/arch/powerpc/platforms/cell/spu_base.c
@@ -715,7 +715,7 @@  static ssize_t spu_stat_show(struct device *dev,
 		spu->stats.libassist);
 }
 
-static DEVICE_ATTR(stat, 0644, spu_stat_show, NULL);
+static DEVICE_ATTR(stat, 0444, spu_stat_show, NULL);
 
 #ifdef CONFIG_KEXEC