From patchwork Sun May 5 20:51:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Tosatti X-Patchwork-Id: 241529 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5A3F72C00E6 for ; Mon, 6 May 2013 06:53:12 +1000 (EST) Received: from localhost ([::1]:33952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZ5vi-0002N0-32 for incoming@patchwork.ozlabs.org; Sun, 05 May 2013 16:53:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZ5vT-0002Mn-UU for qemu-devel@nongnu.org; Sun, 05 May 2013 16:52:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZ5vS-0008HU-VU for qemu-devel@nongnu.org; Sun, 05 May 2013 16:52:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZ5vS-0008FO-Nv for qemu-devel@nongnu.org; Sun, 05 May 2013 16:52:54 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r45Kqp6E013099 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 5 May 2013 16:52:51 -0400 Received: from amt.cnet (vpn1-4-52.gru2.redhat.com [10.97.4.52]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r45Kqo0W002197; Sun, 5 May 2013 16:52:51 -0400 Received: from amt.cnet (localhost [127.0.0.1]) by amt.cnet (Postfix) with ESMTP id 5A54A102BF5; Sun, 5 May 2013 17:51:51 -0300 (BRT) Received: (from marcelo@localhost) by amt.cnet (8.14.6/8.14.6/Submit) id r45KpoBD002070; Sun, 5 May 2013 17:51:50 -0300 Date: Sun, 5 May 2013 17:51:49 -0300 From: Marcelo Tosatti To: Jan Kiszka Message-ID: <20130505205149.GA2032@amt.cnet> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: qemu-devel , kvm-devel Subject: [Qemu-devel] [uq/master PATCH] kvmvapic: add ioport read accessor X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Necessary since memory region accessor assumes read and write methods are registered. Otherwise reading I/O port 0x7e segfaults. https://bugzilla.redhat.com/show_bug.cgi?id=954306 Signed-off-by: Marcelo Tosatti Reviewed-by: Jan Kiszka diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c index 5b558aa..655483b 100644 --- a/hw/i386/kvmvapic.c +++ b/hw/i386/kvmvapic.c @@ -687,8 +687,14 @@ static void vapic_write(void *opaque, hwaddr addr, uint64_t data, } } +static uint64_t vapic_read(void *opaque, hwaddr addr, unsigned size) +{ + return 0xffffffff; +} + static const MemoryRegionOps vapic_ops = { .write = vapic_write, + .read = vapic_read, .endianness = DEVICE_NATIVE_ENDIAN, };