Patchwork mtd: fix kfree bcm47xxsflash

login
register
mail settings
Submitter chenlibo.3@gmail.com
Date May 5, 2013, 8:40 a.m.
Message ID <1367743225-3484-1-git-send-email-libo.chen@huawei.com>
Download mbox | patch
Permalink /patch/241505/
State New
Headers show

Comments

chenlibo.3@gmail.com - May 5, 2013, 8:40 a.m.
From: Libo Chen <libo.chen@huawei.com>

mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash  not its member.

Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
 drivers/mtd/devices/bcm47xxsflash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Libo Chen - May 15, 2013, 3:54 a.m.
Hi David,
	what do you think of this patch ?

On 2013/5/5 16:40, chenlibo.3@gmail.com wrote:
> From: Libo Chen <libo.chen@huawei.com>
> 
> mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash  not its member.
> 
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
> ---
>  drivers/mtd/devices/bcm47xxsflash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c
> index 9526628..4aa9141 100644
> --- a/drivers/mtd/devices/bcm47xxsflash.c
> +++ b/drivers/mtd/devices/bcm47xxsflash.c
> @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
>  	return 0;
>  
>  err_dev_reg:
> -	kfree(&b47s->mtd);
> +	kfree(b47s);
>  out:
>  	return err;
>  }
>

Patch

diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c
index 9526628..4aa9141 100644
--- a/drivers/mtd/devices/bcm47xxsflash.c
+++ b/drivers/mtd/devices/bcm47xxsflash.c
@@ -76,7 +76,7 @@  static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
 	return 0;
 
 err_dev_reg:
-	kfree(&b47s->mtd);
+	kfree(b47s);
 out:
 	return err;
 }