Patchwork samba: add option for built-in debug messages

login
register
mail settings
Submitter Gustavo Zacarias
Date May 4, 2013, 12:06 p.m.
Message ID <1367669205-1745-1-git-send-email-gustavo@zacarias.com.ar>
Download mbox | patch
Permalink /patch/241446/
State Accepted
Commit e5627bd798a2291f36326558d7cbe1e8f6bb01e1
Headers show

Comments

Gustavo Zacarias - May 4, 2013, 12:06 p.m.
This option allows users to specify the maximum level for compiled-in
debug messages with -1 being none.
In a typical scenario of nmbd+smbd+smbpasswd this can save a full
megabyte of target space.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/samba/Config.in | 8 ++++++++
 package/samba/samba.mk  | 3 +++
 2 files changed, 11 insertions(+)
Peter Korsgaard - May 4, 2013, 1:04 p.m.
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 Gustavo> This option allows users to specify the maximum level for compiled-in
 Gustavo> debug messages with -1 being none.
 Gustavo> In a typical scenario of nmbd+smbd+smbpasswd this can save a full
 Gustavo> megabyte of target space.

Committed, thanks.

Patch

diff --git a/package/samba/Config.in b/package/samba/Config.in
index fedbccd..0ab67ed 100644
--- a/package/samba/Config.in
+++ b/package/samba/Config.in
@@ -13,6 +13,14 @@  config BR2_PACKAGE_SAMBA
 
 if BR2_PACKAGE_SAMBA
 
+config BR2_PACKAGE_SAMBA_MAX_DEBUGLEVEL
+	int "Maximum level of compiled-in debug messages"
+	range -1 10000
+	default -1
+	help
+	  Define the level of compiled-in debug messages.
+	  This allows for big space savings, -1 being the lowest (none).
+
 config BR2_PACKAGE_SAMBA_LIBICONV
 	bool "extended encodings (libiconv)"
 	depends on !BR2_ENABLE_LOCALE
diff --git a/package/samba/samba.mk b/package/samba/samba.mk
index 3a004e1..683c7b2 100644
--- a/package/samba/samba.mk
+++ b/package/samba/samba.mk
@@ -158,6 +158,9 @@  else
 SAMBA_CONF_OPT += --with-libiconv=""
 endif
 
+# Compiled debug messages by level
+SAMBA_CONF_OPT += CFLAGS="$(TARGET_CFLAGS) -DMAX_DEBUG_LEVEL=$(BR2_PACKAGE_SAMBA_MAX_DEBUGLEVEL)"
+
 ifeq ($(BR2_PACKAGE_SAMBA_SWAT),y)
 ifneq ($(BR2_HAVE_DOCUMENTATION),y)
 SAMBA_POST_INSTALL_TARGET_HOOKS += SAMBA_REMOVE_SWAT_DOCUMENTATION