Patchwork [U-Boot,2/6] README: mx28_common: Do not hardcode the SSP port

login
register
mail settings
Submitter Fabio Estevam
Date May 3, 2013, 6:07 p.m.
Message ID <1367604482-20955-2-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/241361/
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - May 3, 2013, 6:07 p.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

MX28 can boot from SSP0 or SSP1, so it is better not to hardcode the SSP port
in the instructions.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 doc/README.mx28_common |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Marek Vasut - May 3, 2013, 7:52 p.m.
Dear Fabio Estevam,

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> MX28 can boot from SSP0 or SSP1, so it is better not to hardcode the SSP
> port in the instructions.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  doc/README.mx28_common |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/doc/README.mx28_common b/doc/README.mx28_common
> index 6618908..bd12cab 100644
> --- a/doc/README.mx28_common
> +++ b/doc/README.mx28_common
> @@ -100,9 +100,7 @@ discussed in the following chapters.
>  -----------------------------------------------------------
> 
>  To boot a MX28 based board from SD, set the boot mode DIP switches
> according -to i.MX28 manual chapter 12.2.1 (Table 12-2), PORT=SSP0, SD/MMC
> master on -SSP0, 3.3V.
> -
> +to i.MX28 manual chapter 12.2.1 (Table 12-2).

Make sure to leave the 3V3 thing there. PORT=SSPn would be a better solution 
here too.

>  An SD card the i.MX28 CPU can use to boot U-Boot must contain a DOS
> partition table, which in turn carries a partition of special type and
> which contains a

Best regards,
Marek Vasut
Fabio Estevam - May 3, 2013, 8:42 p.m.
On Fri, May 3, 2013 at 4:52 PM, Marek Vasut <marex@denx.de> wrote:

>>  To boot a MX28 based board from SD, set the boot mode DIP switches
>> according -to i.MX28 manual chapter 12.2.1 (Table 12-2), PORT=SSP0, SD/MMC
>> master on -SSP0, 3.3V.
>> -
>> +to i.MX28 manual chapter 12.2.1 (Table 12-2).
>
> Make sure to leave the 3V3 thing there. PORT=SSPn would be a better solution
> here too.

Sorry, but I disagree.

Please check table 12-2 from mx28 reference manual and you will see
that SD boot is also possible in 1.8V, so in the common README file it
makes no sense to hardcode the boot voltage. Besides that, mx23 does
not refer to 3.3V in its boot mode table.

PORT=SSPn is also noisy. Let's get rid of all this. People will have
to look the reference manual anyway.

Also, in v2 I will change "set the boot mode DIP switches" to "set the
boot mode pins", as not all boards use DIP switches.
Marek Vasut - May 3, 2013, 8:47 p.m.
Dear Fabio Estevam,

> On Fri, May 3, 2013 at 4:52 PM, Marek Vasut <marex@denx.de> wrote:
> >>  To boot a MX28 based board from SD, set the boot mode DIP switches
> >> 
> >> according -to i.MX28 manual chapter 12.2.1 (Table 12-2), PORT=SSP0,
> >> SD/MMC master on -SSP0, 3.3V.
> >> -
> >> +to i.MX28 manual chapter 12.2.1 (Table 12-2).
> > 
> > Make sure to leave the 3V3 thing there. PORT=SSPn would be a better
> > solution here too.
> 
> Sorry, but I disagree.
> 
> Please check table 12-2 from mx28 reference manual and you will see
> that SD boot is also possible in 1.8V, so in the common README file it
> makes no sense to hardcode the boot voltage. Besides that, mx23 does
> not refer to 3.3V in its boot mode table.

When was the last time you saw 1V8 SD card ? ;-)

> PORT=SSPn is also noisy. Let's get rid of all this. People will have
> to look the reference manual anyway.
> 
> Also, in v2 I will change "set the boot mode DIP switches" to "set the
> boot mode pins", as not all boards use DIP switches.

Best regards,
Marek Vasut
Stefano Babic - June 26, 2013, 3:42 p.m.
On 03/05/2013 20:07, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> MX28 can boot from SSP0 or SSP1, so it is better not to hardcode the SSP port
> in the instructions.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/doc/README.mx28_common b/doc/README.mx28_common
index 6618908..bd12cab 100644
--- a/doc/README.mx28_common
+++ b/doc/README.mx28_common
@@ -100,9 +100,7 @@  discussed in the following chapters.
 -----------------------------------------------------------
 
 To boot a MX28 based board from SD, set the boot mode DIP switches according
-to i.MX28 manual chapter 12.2.1 (Table 12-2), PORT=SSP0, SD/MMC master on
-SSP0, 3.3V.
-
+to i.MX28 manual chapter 12.2.1 (Table 12-2).
 
 An SD card the i.MX28 CPU can use to boot U-Boot must contain a DOS partition
 table, which in turn carries a partition of special type and which contains a