Patchwork [1/3] mtd: onenand/generic: Remove redundant platform_set_drvdata()

login
register
mail settings
Submitter Sachin Kamat
Date May 3, 2013, 11:37 a.m.
Message ID <1367581063-24295-1-git-send-email-sachin.kamat@linaro.org>
Download mbox | patch
Permalink /patch/241275/
State New
Headers show

Comments

Sachin Kamat - May 3, 2013, 11:37 a.m.
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/mtd/onenand/generic.c |    2 --
 1 file changed, 2 deletions(-)
Sachin Kamat - June 4, 2013, 12:02 p.m.
On 3 May 2013 17:07, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  drivers/mtd/onenand/generic.c |    2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/onenand/generic.c b/drivers/mtd/onenand/generic.c
> index 9f11562..42520a3 100644
> --- a/drivers/mtd/onenand/generic.c
> +++ b/drivers/mtd/onenand/generic.c
> @@ -94,8 +94,6 @@ static int generic_onenand_remove(struct platform_device *pdev)
>         struct resource *res = pdev->resource;
>         unsigned long size = resource_size(res);
>
> -       platform_set_drvdata(pdev, NULL);
> -
>         if (info) {
>                 onenand_release(&info->mtd);
>                 release_mem_region(res->start, size);
> --
> 1.7.9.5
>


Ping on this series.
Artem Bityutskiy - July 1, 2013, 5:13 a.m.
On Fri, 2013-05-03 at 17:07 +0530, Sachin Kamat wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>

Pushed to l2-mtd.git, thanks!

Patch

diff --git a/drivers/mtd/onenand/generic.c b/drivers/mtd/onenand/generic.c
index 9f11562..42520a3 100644
--- a/drivers/mtd/onenand/generic.c
+++ b/drivers/mtd/onenand/generic.c
@@ -94,8 +94,6 @@  static int generic_onenand_remove(struct platform_device *pdev)
 	struct resource *res = pdev->resource;
 	unsigned long size = resource_size(res);
 
-	platform_set_drvdata(pdev, NULL);
-
 	if (info) {
 		onenand_release(&info->mtd);
 		release_mem_region(res->start, size);