From patchwork Fri May 3 11:23:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joern Rennecke X-Patchwork-Id: 241272 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id AC5EE2C00D4 for ; Fri, 3 May 2013 21:23:43 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:to:subject:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=NB0LO18FT+SvFdSw En2M8CUhpomwX+qlRS7P8B2KMNf9U6L8TA7upY+G3ZbMRfyzcXi9LjeoTTXCU9+c 896OEKaISM4VMKIm+kcvsaCkC+4IjxOImE9h+fSdNEC8kHGXu344mTEWfRhlOoCE tmI+xjReEQ7TtTJpbfqg9BW9M50= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:to:subject:mime-version:content-type :content-transfer-encoding; s=default; bh=cC2ag10KX/1l3QgGx4CgKX rPxNk=; b=V+Q/vwum08Rolwcszqj2AmX4xVx9Y5REKf/8Zu8YKotPkPJg6ZGe0m 6ToovuTLwSe6qHO98x6bQn6ZMYqk4CBJ1AZDgOvVuO0tBjErzuiHuBhn1q5qo0hI jr49p1CpfDAMtEnxMsrgaLi1XGowEJHVcDPII+UCxdxxc+6i19BTY= Received: (qmail 24433 invoked by alias); 3 May 2013 11:23:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 24423 invoked by uid 89); 3 May 2013 11:23:37 -0000 X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_MED, TW_TM autolearn=ham version=3.3.1 Received: from c62.cesmail.net (HELO c62.cesmail.net) (216.154.195.54) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 03 May 2013 11:23:36 +0000 Received: from unknown (HELO delta2) ([192.168.1.50]) by c62.cesmail.net with ESMTP; 03 May 2013 07:23:34 -0400 Received: from cust213-dsl91-135-11.idnet.net (cust213-dsl91-135-11.idnet.net [91.135.11.213]) by webmail.spamcop.net (Horde MIME library) with HTTP; Fri, 03 May 2013 07:23:34 -0400 Message-ID: <20130503072334.ckbodiwygcs8wswo-nzlynne@webmail.spamcop.net> Date: Fri, 03 May 2013 07:23:34 -0400 From: Joern Rennecke To: gcc-patches@gcc.gnu.org Subject: Committed: fix PR tree-optimization/57027 MIME-Version: 1.0 User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) X-Virus-Found: No Bootstrapped & regtested on i686-pc-linux-gnu. Committed, as reviewed by Richard Biener: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57027 and also arguably obvious. 2013-05-03 Joern Rennecke PR tree-optimization/57027 * tree-ssa-math-opts.c (convert_mult_to_fma): When checking for fnms opportunity, check we got the prerequisite kind of tree / gimple before using accessor functions. Index: tree-ssa-math-opts.c =================================================================== --- tree-ssa-math-opts.c (revision 198552) +++ tree-ssa-math-opts.c (working copy) @@ -2581,11 +2581,15 @@ convert_mult_to_fma (gimple mul_stmt, tr && optab_handler (fnma_optab, TYPE_MODE (type)) != CODE_FOR_nothing) { tree rhs2 = gimple_assign_rhs2 (use_stmt); - gimple stmt2 = SSA_NAME_DEF_STMT (rhs2); - if (has_single_use (rhs2) - && gimple_assign_rhs_code (stmt2) == MULT_EXPR) - return false; + if (TREE_CODE (rhs2) == SSA_NAME) + { + gimple stmt2 = SSA_NAME_DEF_STMT (rhs2); + if (has_single_use (rhs2) + && is_gimple_assign (stmt2) + && gimple_assign_rhs_code (stmt2) == MULT_EXPR) + return false; + } } /* We can't handle a * b + a * b. */