From patchwork Fri May 3 06:40:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241219 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-vb0-x23c.google.com (mail-vb0-x23c.google.com [IPv6:2607:f8b0:400c:c02::23c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 398662C00B2 for ; Fri, 3 May 2013 16:40:04 +1000 (EST) Received: by mail-vb0-f60.google.com with SMTP id x16sf365283vbf.15 for ; Thu, 02 May 2013 23:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :subject:date:message-id:mime-version:x-mailer:thread-index :x-brightmail-tracker:x-brightmail-tracker:dlp-filter:x-mtr :x-cfilter-loop:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-language; bh=xevKWNpV23rp/8gZas8OrRzIuAax1jWCMGneZ83aKZE=; b=W8/pMHRyODGbDB3xj1ojajkT8cEydfS8wx9m4A+ptA0BKdozbxKQHM5J/2v7MTiFG3 U2CVKyGdzzHIbxUUeK88jiAsm0GVf6UUiuO3FDVSb5Ph3/yBprSlavGfNIiRxsHpa0+o f62+DH7lQnKk9M837TdzMY8CpQK/0p7YpWo6XwACxJ4UST8OXmCpsduUnIH2U0rcfn74 NQfQu57Be/SkArQNQKlYj8MxrEpmgyOeLV19cgnLzXN3vSPmcDMyxwUt4O5tehh9vEPO n9+odxZKLFWb7QVzHA74HYKqqrG/txgqBfmA8OnWu2i95ROudJxpidv4stfz9p+nKcpl PCmQ== X-Received: by 10.50.50.205 with SMTP id e13mr3863891igo.4.1367563202395; Thu, 02 May 2013 23:40:02 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.92.98 with SMTP id cl2ls240054igb.32.canary; Thu, 02 May 2013 23:40:02 -0700 (PDT) X-Received: by 10.68.108.165 with SMTP id hl5mr3139758pbb.4.1367563202045; Thu, 02 May 2013 23:40:02 -0700 (PDT) Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by gmr-mx.google.com with ESMTP id fn10si1788824pab.1.2013.05.02.23.40.01 for ; Thu, 02 May 2013 23:40:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) client-ip=203.254.224.25; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM700K6OMIKB450@mailout2.samsung.com> for rtc-linux@googlegroups.com; Fri, 03 May 2013 15:40:01 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id F9.5F.04074.1CB53815; Fri, 03 May 2013 15:40:01 +0900 (KST) X-AuditID: cbfee690-b7f136d000000fea-c7-51835bc158de Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id B7.8F.01422.0CB53815; Fri, 03 May 2013 15:40:00 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM70016XMIOFFB0@mmp1.samsung.com>; Fri, 03 May 2013 15:40:00 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, juhosg@openwrt.org Subject: [rtc-linux] [PATCH 41/42] rtc: rtc-rp5c01: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:40:00 +0900 Message-id: <003701ce47c9$0941aa20$1bc4fe60$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5HyQhuIb21znUtR7e/MRy8TLcZdA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsVy+t8zA92D0c2BBiuamC2WXLzKbjFn/Ro2 i0tTLjFZXN41h81if2cHowOrx56JJ9k8Tsz4zeKxZXGGx/R5P5k8Pm+SC2CN4rJJSc3JLEst 0rdL4Mo49+Ace8EOzopvX2ayNDDeYu9i5OSQEDCRaJmwhBnCFpO4cG89WxcjF4eQwDJGiSt9 b1lhij4+usgOkVjEKHH192QmCOcXo8Ss059YQKrYBNQkvnw5DFTFwSEioC/R1qIBEmYWqJVY 1f+SCcQWFgiW+Nl3lw3EZhFQlTjw8wxYnFfAUuLMpE/MELagxI/J91ggerUk1u88zgRhy0ts XvMW6lIFiR1nXzOC2CICehK/pj1nhagRkdj34h0jyG0SAofYJW4u6GGCWCYg8W3yIRaQ2yQE ZCU2HYCaIylxcMUNlgmMYrOQrJ6FZPUsJKtnIVmxgJFlFaNoakFyQXFSepGJXnFibnFpXrpe cn7uJkZI5E3YwXjvgPUhxmSg9ROZpUST84GRm1cSb2hsZmRhamJqbGRuaUaasJI4r3qLdaCQ QHpiSWp2ampBalF8UWlOavEhRiYOTqkGxvBH6/cFrfpgY2BYbTlZlU31vLfiq36R+Rn9u69w ui+WiXzo6bHHde/SRyXqSvJ3Dsj2l4ib9s6unF93dPka6ZuVv5nSJ/xQ4GPNtNQN5jpR/Pai 1NJv8UV2hz8cX3fZdgWDzLOknriEgjahVeE+tgEzjn98bnrs/nHzY09kXbKV1pgILI2pUmIp zkg01GIuKk4EADJnu1TSAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsVy+t9jAd0D0c2BBhs221gsuXiV3WLO+jVs FpemXGKyuLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Vjy+IMj+nzfjJ5fN4kF8Aa1cBok5GamJJa pJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeYm2qr5OIToOuWmQO0XEmhLDGnFCgUkFhc rKRvh2lCaIibrgVMY4Sub0gQXI+RARpIWMeYce7BOfaCHZwV377MZGlgvMXexcjJISFgIvHx 0UUoW0ziwr31bF2MXBxCAosYJa7+nswE4fxilJh1+hMLSBWbgJrEly+HgTo4OEQE9CXaWjRA wswCtRKr+l8ygdjCAsESP/vusoHYLAKqEgd+ngGL8wpYSpyZ9IkZwhaU+DH5HgtEr5bE+p3H mSBseYnNa94yQxykILHj7GtGEFtEQE/i17TnrBA1IhL7XrxjnMAoMAvJqFlIRs1CMmoWkpYF jCyrGEVTC5ILipPSc430ihNzi0vz0vWS83M3MYLj+pn0DsZVDRaHGAU4GJV4eBVamgKFWBPL iitzDzFKcDArifC6/QAK8aYkVlalFuXHF5XmpBYfYkwG+nQis5Rocj4w5eSVxBsam5gZWRqZ WRiZmJuTJqwkznuw1TpQSCA9sSQ1OzW1ILUIZgsTB6dUA2POY/kHnDkBAg4SUy+ZF+cWS/+r 3/Vli1jJ5I5dK0rbtm9/ryO095lmRcjzUyXHSoMWSV9llTl4PTt/95OWmtNT1TM8Jje5H/av XfG/wiSb+Y1P+dmVFj3VrAWue/w2ck32nNwSdcmSyTSnptf5xaIvHIe2JCZEWr5/IfOh+WEA x5VZQkcmzVBiKc5INNRiLipOBADVeSFLLwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-rp5c01.c | 12 +++--------- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-rp5c01.c b/drivers/rtc/rtc-rp5c01.c index 873c689..89d0736 100644 --- a/drivers/rtc/rtc-rp5c01.c +++ b/drivers/rtc/rtc-rp5c01.c @@ -251,21 +251,15 @@ static int __init rp5c01_rtc_probe(struct platform_device *dev) rtc = devm_rtc_device_register(&dev->dev, "rtc-rp5c01", &rp5c01_rtc_ops, THIS_MODULE); - if (IS_ERR(rtc)) { - error = PTR_ERR(rtc); - goto out; - } + if (IS_ERR(rtc)) + return PTR_ERR(rtc); priv->rtc = rtc; error = sysfs_create_bin_file(&dev->dev.kobj, &priv->nvram_attr); if (error) - goto out; + return error; return 0; - -out: - platform_set_drvdata(dev, NULL); - return error; } static int __exit rp5c01_rtc_remove(struct platform_device *dev)