Patchwork [40/42] rtc: rtc-puv3: remove unnecessary platform_set_drvdata()

login
register
mail settings
Submitter Jingoo Han
Date May 3, 2013, 6:39 a.m.
Message ID <003601ce47c8$f9aa1e30$ecfe5a90$@samsung.com>
Download mbox | patch
Permalink /patch/241218/
State New
Headers show

Comments

Jingoo Han - May 3, 2013, 6:39 a.m.
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/rtc/rtc-puv3.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Guan Xuetao - May 3, 2013, 4:30 p.m.
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Thanks.

Acked-by: Guan Xuetao <gxt@mprc.pku.edu.cn>

> ---
>  drivers/rtc/rtc-puv3.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c
> index 72f4371..402732c 100644
> --- a/drivers/rtc/rtc-puv3.c
> +++ b/drivers/rtc/rtc-puv3.c
> @@ -224,7 +224,6 @@ static int puv3_rtc_remove(struct platform_device
> *dev)
>  {
>  	struct rtc_device *rtc = platform_get_drvdata(dev);
>
> -	platform_set_drvdata(dev, NULL);
>  	rtc_device_unregister(rtc);
>
>  	puv3_rtc_setpie(&dev->dev, 0);
> --
> 1.7.2.5
>
>

Patch

diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c
index 72f4371..402732c 100644
--- a/drivers/rtc/rtc-puv3.c
+++ b/drivers/rtc/rtc-puv3.c
@@ -224,7 +224,6 @@  static int puv3_rtc_remove(struct platform_device *dev)
 {
 	struct rtc_device *rtc = platform_get_drvdata(dev);
 
-	platform_set_drvdata(dev, NULL);
 	rtc_device_unregister(rtc);
 
 	puv3_rtc_setpie(&dev->dev, 0);