Patchwork [38/42] rtc: rtc-vt8500: remove unnecessary platform_set_drvdata()

login
register
mail settings
Submitter Jingoo Han
Date May 3, 2013, 6:38 a.m.
Message ID <003401ce47c8$cf834140$6e89c3c0$@samsung.com>
Download mbox | patch
Permalink /patch/241216/
State New
Headers show

Comments

Jingoo Han - May 3, 2013, 6:38 a.m.
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/rtc/rtc-vt8500.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Tony Prisk - May 3, 2013, 7:27 a.m.
On 03/05/13 18:38, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>   drivers/rtc/rtc-vt8500.c |    2 --
>   1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-vt8500.c b/drivers/rtc/rtc-vt8500.c
> index d89efee..c2d6331 100644
> --- a/drivers/rtc/rtc-vt8500.c
> +++ b/drivers/rtc/rtc-vt8500.c
> @@ -282,8 +282,6 @@ static int vt8500_rtc_remove(struct platform_device *pdev)
>   	/* Disable alarm matching */
>   	writel(0, vt8500_rtc->regbase + VT8500_RTC_IS);
>   
> -	platform_set_drvdata(pdev, NULL);
> -
>   	return 0;
>   }
>   
Acked-by: Tony Prisk <linux@prisktech.co.nz>

Patch

diff --git a/drivers/rtc/rtc-vt8500.c b/drivers/rtc/rtc-vt8500.c
index d89efee..c2d6331 100644
--- a/drivers/rtc/rtc-vt8500.c
+++ b/drivers/rtc/rtc-vt8500.c
@@ -282,8 +282,6 @@  static int vt8500_rtc_remove(struct platform_device *pdev)
 	/* Disable alarm matching */
 	writel(0, vt8500_rtc->regbase + VT8500_RTC_IS);
 
-	platform_set_drvdata(pdev, NULL);
-
 	return 0;
 }